Boss Bars

[AnOwlBe]

Problem

Bossbars have existed in Minecraft since 1.9 and even now days are used by almost every server for some thing whether its a timer for an event or a way to display a store sale.

Solution

After like 4 previous attempts I am here to finally hopefully probably not maybe implement boss bars into skript!

I've implemented the following syntaxes:
expressions:
ExprAllBossBars - gets all persistent/keyed boss bars
ExprBossBarFromEntity - gets a none keyed boss bar from an entity (entity must be a wither or ender dragon)
ExprBossBarFromKey - gets a persistent/keyed boss bar from a key
sections:
ExprSecCreateBossBar - the base of boss bar creation allows for creation of a normal (temporary) bossbar or a keyed one (saved across restarts & requires a key upon creation)
conditions:
CondHasBossBarFlag - checks if a boss bar (keyed or not) has a flag
effects:
EffBossBarFlags - makes a boss bar have or not have a specific flag

properties:
I've registered 4 new properties:
PropExprProgress
PropExprTitle
PropExprStyle
PropExprViewers

propertyexpressions:

title - used to get/set/reset the title of a boss bar
Also deprecated ExprBookTitle and for the itemtypeclassinfo implemented a way to get/set the title of a signed book eg send title of tool of me

---

progress - used to get/set/add/reset/remove from the progress of a boss bar
style - used to get/set/reset the style of a boss bar
viewers - used to get/set/reset/add/remove the viewers of a boss bar

Testing Completed

manual testing completed for all elements everything appears to work fine no errors in console makes the bossbar sets title etc
I have implemented tests for all added features all tests pass

changes:
Changed ExprColorOf to be in skriptlang -> bukkit folder and use the newer registry syntax while also removing the check for displays of is running 1.19.4 as skript's lowest supported version is 1.21.1
also changed it to support setting the color of a boss bar
while on the topic I have added LabColor this is used in BossBarUtils to round a skript color to the nearest boss bar color (credit to @UnderscoreTud for the labcolor)

I think that sums up what I have implemented/changed in this PR though I probably missed a thing or two

Supporting Information

There is a LOT and I mean a LOT to discuss in this pr so far from what i've gathered the following things need to be discussed:

1# Should we be using bukkit or adventure boss bars (already discussed but still open if anyone wants to add to it) due to adventure boss bars missing a lot of stuff like getting boss bar from a boss
2# Should the creation syntax for bossbars include color/title so far it includes color (red boss bar eg) but I feel like adding title is too much but that is why its up for discussion!
3# Should we allow for creation of none keyed bossbars? there must be support for regular boss bars that is a must but for creation via the exprsec should it be allowed?
4# For the progress propertyexpr should setting progress of a bossbar work via 0.0 to 1.0 or 0 to 100 both bukkit & adventure API use 0.0 to 1.0 but 0 to 100 may be easier for users to understand (currently method is 0.0 to 1.0 and is usable eg like set progress of event-bossbar to 43%
5# I forgot the other discussions I think that is all of the important ones

---

Completes: #8491
Related: #6986 #5246 #3995 #3263
AI assistance: claude for nearest utility & small things here and there

[sovdeeth]

mainly looked at patterns
also needs tests

[Absolutionism]

Some of my requested changes may have already been covered by Sovde, as he finished his first

[APickledWalrus]

This is some really good work so far! I might like to see more tests as well (ideally full coverage). Thanks for your continued work on this 🙂

[AnOwlBe]

Okay I think I've resolved all requests besides ones pending on an answer from sovde or you pickle

Though I probably did miss some/incorrectly resolved an issue so let me know

[AnOwlBe]

for more tests I think I covered everything what elements did I miss?

[APickledWalrus]

for more tests I think I covered everything what elements did I miss?

Oh yeah coverage is better than I thought - my mistake. I think the only thing not tested is ExprBossBarFromEntity - you should be able to spawn a boss mob (wither) and test it?

[APickledWalrus]

This is looking really strong! Most of these suggestions are related to formatting and/or wording. I think this is nearly ready 🙂

[APickledWalrus]

You would just add some new patterns. Simply adjust how add is determined: also consider matched pattern