Updates for worldborders#8659
Open
AnOwlBe wants to merge 45 commits into
Open
Conversation
AnOwlBe
requested review from
Burbulinis and
erenkarakal
and removed request for
a team
skriptlang-automation
Bot
added
needs reviews
This comment has been minimized.
This comment has been minimized.
skriptlang-automation
Bot
added
enhancement
Efnilite
requested changes
May 25, 2026
…s/expressions/ExprWorldBorderWarningTime.java Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
…s/expressions/ExprWorldBorder.java Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
…s/WorldBorderModule.java Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
…s/WorldBorderModule.java Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
…s/WorldBorderModule.java Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
… add/set/remove NaN/infinity/-infinity
APickledWalrus
requested changes
May 27, 2026
APickledWalrus
left a comment
APickledWalrus
left a comment
Member
There was a problem hiding this comment.
Looking good so far. Indentation is cooked for a lot of the register methods - I covered some but there are more, so I recommend going back through those files.
skriptlang-automation
Bot
removed
the
needs reviews
…s/expressions/ExprSecCreateWorldBorder.java Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>
…s/WorldBorderModule.java Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>
Author
|
Okay I think I fixed everything @APickledWalrus ^ |
sovdeeth
approved these changes
May 28, 2026
sovdeeth
left a comment
sovdeeth
left a comment
Member
There was a problem hiding this comment.
looks good, just some weird formatting issues
…s/expressions/ExprWorldBorderDamageBuffer.java Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
…s/expressions/ExprWorldBorderDamageAmount.java Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
…s/expressions/ExprWorldBorderWarningTime.java Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
Author
okay I just ran it through a spaces to tabs converter n pasted it so it should be completely tabs
|
Member
It didn't fix the ones pickle commented on (ExprWorldBorderDamageAmount for example) and there's still a few with the closing |
Author
|
okay I fixed all extra tab for } for register methods |
Absolutionism
requested changes
May 28, 2026
Co-authored-by: Patrick Miller <apickledwalrus@icloud.com> Co-authored-by: SirSmurfy2 <82696841+Absolutionism@users.noreply.github.com>
Absolutionism
requested changes
Jun 9, 2026
Absolutionism
approved these changes
Jun 10, 2026
APickledWalrus
requested changes
Jun 12, 2026
APickledWalrus
left a comment
APickledWalrus
left a comment
Member
There was a problem hiding this comment.
A few minor things, almost there!
…s/WorldBorderModule.java Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
All worldborder elements were running on deprecated registration methods as well as worldborder events being in the god awful simpleevents while also using deprecated registration methods
additionally worldborderwarningtime was using deprecated methods to set/get duration (old method used seconds via long newer method simply uses ticks)
Solution
Deletes all worldborder elements including events
Creates a worldbordermodule
Re adds all worldborder elements including events to use new registry & event-value registry system
Makes versions >= 1.21.11 use the newer method for get/setting warningtime for worldborders older versions fallback to the older method
Changes to tests:
changed test for warningtime when using >= 1.21.11
changed all worldborder tests to use 'catch runtime errors' when getting/setting/removing NaN/infinity/-infinity
Testing Completed
Manual testing completed everything works (though additional testing should be done on lower versions as I only tested on 1.21.11)
Supporting Information
I think registering all the worldborder events & event-values should each be their old file inside elements -> events though I would like confirmation on this before doing (right now its all registered in worldbordermodule)
Completes: none
Related: replaces #8504
AI assistance: next to none
overall this is mostly an internal PR nothing for the user really changes (for the most part there are some things)