Skip to content

Conversation

@HarshMehta112
Copy link
Contributor

Fix case-sensitivity bug in auto reload recipients (#8290)

Description:
This PR makes the matching of auto reload recipients case-insensitive. Previously, usernames had to match exactly in case for reload notifications to work — now, any case variation will be accepted.

Changes:

Normalize recipient strings (e.g. to lowercase) for comparison

Preserve original case for display if needed

Fixes: #8290

Signed-off-by: Harsh Mehta <harshmehta010102@gmail.com>
@HarshMehta112 HarshMehta112 requested a review from a team as a code owner November 22, 2025 06:46
@HarshMehta112 HarshMehta112 requested review from Pesekjak and TheMug06 and removed request for a team November 22, 2025 06:46
@sovdeeth
Copy link
Member

Hi, please use the proper PR template. You should be able to edit your description to amend it.

@sovdeeth sovdeeth changed the base branch from master to dev/patch November 22, 2025 07:15
@sovdeeth sovdeeth added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Nov 22, 2025
@sovdeeth sovdeeth moved this to In Progress in 2.13 Releases Nov 22, 2025
@sovdeeth sovdeeth moved this from In Progress to In Review in 2.13 Releases Nov 22, 2025
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Nov 22, 2025
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The recipient != null check technically isn't necessary (the @nullable should be on ... instead of on String) but that's not something you have to fix here.

@github-project-automation github-project-automation bot moved this from In Review to Awaiting Merge in 2.13 Releases Nov 23, 2025
@skriptlang-automation skriptlang-automation bot added patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. and removed needs reviews A PR that needs additional reviews labels Nov 23, 2025
@sovdeeth sovdeeth merged commit 3add02d into SkriptLang:dev/patch Dec 1, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done - Awaiting Release in 2.13 Releases Dec 1, 2025
@skriptlang-automation skriptlang-automation bot added completed The issue has been fully resolved and the change will be in the next Skript update. and removed patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. labels Dec 1, 2025
@sovdeeth sovdeeth moved this from Done - Awaiting Release to Done - Released in 2.13 Releases Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update.

Projects

Status: Done - Released

Development

Successfully merging this pull request may close these issues.

Auto reload case sensitive

4 participants