Proof: beforeunload test fails on main

.azure-pipelines/publish.yml

@@ -40,6 +40,10 @@ extends:
           inputs:
             versionSpec: '3.9'
           displayName: 'Use Python'
+        - task: NodeTool@0
+          inputs:
+            versionSpec: '24.x'
+          displayName: 'Use Node.js'
         - script: |
             python -m pip install --upgrade pip
             pip install -r local-requirements.txt
@@ -60,7 +64,7 @@ extends:
             targetPath: $(Build.ArtifactStagingDirectory)/esrp-build
         steps:
           - checkout: none
-          - task: EsrpRelease@9
+          - task: EsrpRelease@11
             inputs:
               connectedservicename: 'Playwright-ESRP-PME'
               usemanagedidentity: true

.claude/skills/playwright-roll/SKILL.md

@@ -5,7 +5,7 @@ description: Roll Playwright Python to a new driver version. Walks the upstream
 
 # Rolling Playwright Python
 
-The goal of a roll is to move `driver_version` in `setup.py` to a new release, port every public API change introduced upstream during that interval, and suppress the rest, so that `./scripts/update_api.sh` runs clean and the test suite still passes.
+The goal of a roll is to move the driver pin in `DRIVER_SHA` to a new release, port every public API change introduced upstream during that interval, and suppress the rest, so that `./scripts/update_api.sh` runs clean and the test suite still passes.
 
 The previous human-facing summary lives in `../../../ROLLING.md`. This skill is the operational playbook — read it end to end before starting.
 
@@ -15,7 +15,7 @@ The Python port is hand-written code in `playwright/_impl/`, plus a generator (`
 
 1. introspects the Python `_impl` classes via `inspect`,
 2. emits typed wrapper classes into `playwright/{async,sync}_api/_generated.py`, and
-3. diffs the introspected surface against `playwright/driver/package/api.json` (downloaded inside the new driver wheel).
+3. diffs the introspected surface against `playwright/driver/package/api.json` (built into the new driver from source).
 
 Anything in `api.json` that is missing or differently typed in `_impl/` causes generation to fail. Three resolutions:
 
@@ -52,18 +52,27 @@ There is sometimes no `vX.Y.0` tag for the latest release (the bots cut release
 - If `python3-venv` is missing system-wide, use `uv venv env` instead, then `uv pip install --python env/bin/python --upgrade pip`. Don't try to `apt install` — sudo is denied in the harness.
 - Always activate the venv before any `pip`, `pytest`, `mypy`, or `pre-commit` invocation.
 
-### 2. Bump the driver and download it
+### 2. Bump the driver and build it from source
 
 ```sh
-# Edit setup.py
-driver_version = "<new>"     # e.g. "1.59.1"
+# Edit DRIVER_SHA (repo root): replace with the microsoft/playwright commit SHA
+# for the new release, e.g. the commit that v<new> points at.
+#   87bb9ddbd78f329df18c2b24847bc9409240cd07
+# Update the "# microsoft/playwright @ v<new>" comment in scripts/build_driver.sh too.
 
 source env/bin/activate
-python -m build --wheel       # downloads the new driver from cdn.playwright.dev
+python -m build --wheel       # clones microsoft/playwright @ DRIVER_SHA and builds the driver from source
 playwright install chromium   # NOT --with-deps; sudo is denied
 ```
 
-The wheel build prints `Fetching https://cdn.playwright.dev/builds/driver/playwright-<new>-linux.zip` and unpacks the driver under `playwright/driver/package/`. From this point, `playwright/driver/package/api.json` reflects the new release.
+The wheel build clones `microsoft/playwright` at the commit in `DRIVER_SHA`
+into `driver/playwright-src`, runs `npm ci && npm run build`, and runs upstream's
+`utils/build/build-playwright-driver.sh` to produce the per-platform driver
+bundles (`driver/playwright-<sha>-*.zip`), then unpacks the driver under
+`playwright/driver/package/`. From this point,
+`playwright/driver/package/api.json` reflects the new release. This requires
+**Node.js, npm, git and bash** on PATH; the first build is slow (full upstream
+build + per-platform Node downloads).
 
 ### 3. Identify the commit range
 
@@ -240,7 +249,7 @@ For each PORT, add one async test and a matching sync test. Conventions:
 
 ### 7. Update existing high-touch artifacts
 
-- `setup.py`: already done in step 2.
+- `DRIVER_SHA` (and the version comment in `scripts/build_driver.sh`): already done in step 2.
 - `README.md`: gets the chromium/firefox/webkit version table updated automatically by `scripts/update_versions.py` (called from `update_api.sh`). Don't edit by hand.
 - The "Backport changes" tracking issue on GitHub (filed by `microsoft-playwright-automation`) is the *intent* tracker, but it's frequently out of sync with what's actually been ported. Treat it as a starting point, not the source of truth — the `docs/src/api/` commit walk is authoritative.
 

.github/workflows/ci.yml

@@ -17,15 +17,43 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
+  build-driver:
+    name: Build driver
+    runs-on: ubuntu-latest
+    timeout-minutes: 60
+    steps:
+    - uses: actions/checkout@v6
+    - name: Set up Node.js
+      uses: actions/setup-node@v4
+      with:
+        node-version: '24'
+    - name: Build driver bundles from source
+      run: bash scripts/build_driver.sh
+    - name: Upload driver bundles
+      uses: actions/upload-artifact@v4
+      with:
+        name: driver-bundles
+        path: driver/playwright-*.zip
+        if-no-files-found: error
+        # The bundles are already-compressed zips; skip re-compression.
+        compression-level: 0
+        retention-days: 1
+
   infra:
     name: Lint
+    needs: build-driver
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v5
+    - uses: actions/checkout@v6
     - name: Set up Python
       uses: actions/setup-python@v6
       with:
         python-version: "3.10"
+    - name: Download driver bundles
+      uses: actions/download-artifact@v4
+      with:
+        name: driver-bundles
+        path: driver/
     - name: Install dependencies & browsers
       run: |
         python -m pip install --upgrade pip
@@ -43,6 +71,7 @@ jobs:
 
   build:
     name: Build
+    needs: build-driver
     timeout-minutes: 45
     strategy:
       fail-fast: false
@@ -91,11 +120,16 @@ jobs:
           browser: chromium
     runs-on: ${{ matrix.os }}
     steps:
-    - uses: actions/checkout@v5
+    - uses: actions/checkout@v6
     - name: Set up Python
       uses: actions/setup-python@v6
       with:
         python-version: ${{ matrix.python-version }}
+    - name: Download driver bundles
+      uses: actions/download-artifact@v4
+      with:
+        name: driver-bundles
+        path: driver/
     - name: Install dependencies & browsers
       run: |
         python -m pip install --upgrade pip
@@ -125,6 +159,7 @@ jobs:
 
   test-stable:
     name: Stable
+    needs: build-driver
     timeout-minutes: 45
     strategy:
       fail-fast: false
@@ -138,11 +173,16 @@ jobs:
           browser-channel: msedge
     runs-on: ${{ matrix.os }}
     steps:
-    - uses: actions/checkout@v5
+    - uses: actions/checkout@v6
     - name: Set up Python
       uses: actions/setup-python@v6
       with:
         python-version: "3.10"
+    - name: Download driver bundles
+      uses: actions/download-artifact@v4
+      with:
+        name: driver-bundles
+        path: driver/
     - name: Install dependencies & browsers
       run: |
         python -m pip install --upgrade pip
@@ -166,43 +206,14 @@ jobs:
       if: matrix.os == 'ubuntu-latest'
       run: xvfb-run pytest tests/async --browser=chromium --browser-channel=${{ matrix.browser-channel }} --timeout 90
 
-  build-conda:
-    name: Conda Build
-    strategy:
-      fail-fast: false
-      matrix:
-        os: [ubuntu-22.04, macos-latest, windows-2022]
-    runs-on: ${{ matrix.os }}
-    defaults:
-      run:
-        # `setup-miniconda` activates the env only for login shells; using
-        # `bash -el` (recommended by the action) ensures `conda` and the
-        # installed `conda-build` are on PATH on every OS, including Windows
-        # where the default shell is pwsh and skips the activation hooks.
-        shell: bash -el {0}
-    steps:
-      - uses: actions/checkout@v5
-        with:
-          fetch-depth: 0
-      - name: Get conda
-        uses: conda-incubator/setup-miniconda@v3
-        with:
-          python-version: '3.12'
-          channels: conda-forge
-          miniconda-version: latest
-      - name: Prepare
-        run: conda install -n base "conda-build>=26" conda-verify
-      - name: Build
-        run: conda build .
-
   test_examples:
     name: Examples
     runs-on: ubuntu-22.04
     defaults:
       run:
         working-directory: examples/todomvc/
     steps:
-    - uses: actions/checkout@v5
+    - uses: actions/checkout@v6
     - name: Set up Python
       uses: actions/setup-python@v6
       with:

.github/workflows/publish_docker.yml

@@ -15,9 +15,9 @@ jobs:
       contents: read    # This is required for actions/checkout to succeed
     environment: Docker
     steps:
-    - uses: actions/checkout@v5
+    - uses: actions/checkout@v6
     - name: Azure login
-      uses: azure/login@v2
+      uses: azure/login@v3
       with:
         client-id: ${{ secrets.AZURE_DOCKER_CLIENT_ID }}
         tenant-id: ${{ secrets.AZURE_DOCKER_TENANT_ID }}
@@ -28,8 +28,12 @@ jobs:
       uses: actions/setup-python@v6
       with:
         python-version: "3.10"
+    - name: Set up Node.js
+      uses: actions/setup-node@v4
+      with:
+        node-version: '24'
     - name: Set up Docker QEMU for arm64 docker builds
-      uses: docker/setup-qemu-action@v3
+      uses: docker/setup-qemu-action@v4
       with:
         platforms: arm64
     - name: Install dependencies & browsers

.github/workflows/test_docker.yml

@@ -30,11 +30,15 @@ jobs:
           - ubuntu-24.04
           - ubuntu-24.04-arm
     steps:
-    - uses: actions/checkout@v5
+    - uses: actions/checkout@v6
     - name: Set up Python
       uses: actions/setup-python@v6
       with:
         python-version: "3.10"
+    - name: Set up Node.js
+      uses: actions/setup-node@v4
+      with:
+        node-version: '24'
     - name: Install dependencies
       run: |
         python -m pip install --upgrade pip
@@ -53,6 +57,10 @@ jobs:
         docker exec "${CONTAINER_ID}" pip install -r local-requirements.txt
         docker exec "${CONTAINER_ID}" pip install -r requirements.txt
         docker exec "${CONTAINER_ID}" pip install -e .
+        # build.sh (above) already built the driver bundles into driver/ on the
+        # host. The repo is bind-mounted into the container, so this in-container
+        # wheel build reuses those bundles (setup.py skips the source build when
+        # the zip already exists) and therefore needs no Node.js in the image.
         docker exec "${CONTAINER_ID}" python -m build --wheel
         docker exec "${CONTAINER_ID}" xvfb-run pytest tests/sync/
         docker exec "${CONTAINER_ID}" xvfb-run pytest tests/async/