feat(aggregation): add Composition class and << operator in _aggregator_bases - #777
Closed
powerofaisinstudy-debug wants to merge 3 commits into
Closed
powerofaisinstudy-debug wants to merge 3 commits into
powerofaisinstudy-debug wants to merge 3 commits into
Conversation
powerofaisinstudy-debug
marked this pull request as ready for review
September 14, 2026 17:37
powerofaisinstudy-debug
requested review from
a team,
KhusPatel4450,
PierreQuinton and
ValerianRey
as code owners
September 14, 2026 17:37
Contributor
|
We consider this as spam. Please refrain from opening PR/issues that are fully AI generated. |
Author
|
Hi @PierreQuinton, I apologize for the impression. I am a real contributor writing and testing this code manually to address the changes discussed earlier. I used an AI tool to help write the PR description formatting, which I now realize came across as automated spam. I completely understand your project guidelines. I'll take a step back and refrain from opening further PRs until I can present human-authored descriptions. Thanks for your time and for maintaining TorchJD! |
powerofaisinstudy-debug
deleted the
feat/aggregator-lshift-composition
branch
September 15, 2026 02:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR follows up on our previous PR #776 regarding declarative pipeline composition (
Aggregator << Transform).Based on feedback from @PierreQuinton, the composition logic has been relocated directly into
src/torchjd/aggregation/_aggregator_bases.py.Key Changes
Compositionclass tosrc/torchjd/aggregation/_aggregator_bases.py.nn.Moduleand definedforwardmethod instead of__call__.TypeVarannotations forouter(aggregator) andinner(callable).__str__to outputstr(outer) + " << " + str(inner).__lshift__tonn.Moduleviacompose.tests/covering execution flow and string formatting.cc @PierreQuinton @ValerianRey