Update CircleCI to retain the built artifacts.#106
Merged
Conversation
Retain the built artifacts in CircleCI. Useful for debugging and possibly manual upload as GitHub release assets. The latter can be done automatically but requires a GitHub Personal Access Token to be set in CircleCI and that requires bot account on the SimpleITK organization and we want to avoid that for now.
zivy
force-pushed
the
updateCircleCIConfig
branch
from
4b67408 to
a5730ff
Compare
Member
|
The comment related to the downgrade of Xcode seem inaccurate. You can use a newer compiler and SDK and target an older OSX version. See CMAKE_OSX_DEPLOYMENT_TARGET for details. |
zivy
force-pushed
the
updateCircleCIConfig
branch
from
2d7d03b to
042fc08
Compare
blowekamp
approved these changes
Jul 8, 2026
blowekamp
left a comment
blowekamp
left a comment
Member
There was a problem hiding this comment.
Nice. Looks about right, but one question.
| export CMAKE_OSX_DEPLOYMENT_TARGET="14" | ||
| elif [ "$OS_ARCH" == "x86_64" ]; then | ||
| # For Intel Macs, target macOS 11 (Big Sur) | ||
| export CMAKE_OSX_DEPLOYMENT_TARGET="11" |
Member
There was a problem hiding this comment.
I have only see the TARGETs include the major.minor e.g. 11->11.0
Do you have a reference for this usage?
Member
Author
There was a problem hiding this comment.
No reference for this usage. Did not think about it when setting per the documentation from the R project, so when they specified 11 I just set it to that without thinking about the major.minor format. It appears to work but I'll change it so that it is clearer.
macOS is designed with forward compatibility, software compiled for older OS version should run on a newer version. To support the largest range of macOS versions, we follow the guidlines from the https://mac.r-project.org/: Starting with R 4.0.0 we are building R using standard Apple tools (Xcode) and GNU Fortran (see tools for downloads and details). We maintain following binary builds: sonoma-arm64 build supports arm64 Macs (M1+) from macOS 14 (Sonoma) and higher (since R 4.6.0) big-sur-x86_64 build supports legacy Intel Macs from macOS 11 (Big Sur) and higher (since R 4.3.0)
zivy
force-pushed
the
updateCircleCIConfig
branch
from
042fc08 to
7b3cec0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retain the built artifacts in CircleCI. Useful
for debugging and possibly manual upload as
GitHub release assets. The latter can be done
automatically but requires a GitHub Personal
Access Token to be set in CircleCI and that
requires bot account on the SimpleITK organization and we want to avoid that for now.