Repository navigation
Move to PlatformHeads 0.12.0 and drop the copies it now holds - #97
Merged
Merged
Conversation
The seven pins move together to 0.12.0, which shares the update report and the menu renderer. The tray reports an update through ToolUpdateOutcome.Report, whose failure says "BuildMonitor did not update" where it said "Update failed". Menus are drawn by PaletteMenuRenderer, made from the palette each time a menu opens, so a menu still follows a change of theme. The tray's items go to the native heads as TrayMenuItem.Flags, of which the ABI carries the first two.
Co-authored-by: SimonCropp <122666+SimonCropp@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PlatformHeads 0.12.0 (PlatformHeads#13) now has the update report and the menu renderer that BuildMonitor kept copies of. This moves the seven pins to 0.12.0 and deletes the copies.
Pins. All seven move to 0.12.0 together.
Update report.
UpdateOutcome.Takegoes throughToolUpdateOutcome.Reportand keeps its log lines.UpdateOutcome.Describeis deleted.Describenow write an outcome file and take it.Menus.
MenuRendererandMenuColoursare deleted.MenuTheme.Applynow assignsPaletteMenuRendererwith aMenuPalettemade from the palette at that moment, using the colours the old table used.Palettewhile drawing, so a menu followed a change of theme. Every menu here callsApplyeach time it opens: the rows' context menu, the select control and the tray, throughNotifyIconOptions.Theme. So the new renderer is made from the current theme whenever a menu opens, and menus still follow a change.SelectedRow, like the start and end of it. The old table left it at the system default.Tray flags.
ScreenPayloadwritesTrayMenuItem.Flagsmasked to Enabled and Separator, which are the same values asBM_TRAY_ENABLEDandBM_TRAY_SEPARATOR.BmFlags.TrayEnabledandTraySeparatorare deleted. The ABI is unchanged, and nothing native changed.Not taken. The flat menu tree in PlatformHeads is for an ABI with submenus and checks.
BmTrayItemhas neither, so nothing here moves ontoStatusMenuItem.tree.Tests. Locally on Windows, the Release build had no errors. The whole solution passed: 1,610 tests, with 14 skipped and none failed. Nothing here snapshots a menu, so no menu was looked at; PlatformHeads'
PaletteMenuRendererTestscover the colour table and the text colours.