Repository navigation
Move PlatformHeads to 0.10.0 - #88
Merged
Merged
Conversation
All seven pins move together: build-native's uses, the CMake GIT_TAG, the four packages and the Swift package. 0.10.0 adds to NotifyIconTray (LeftClickOpensMenu, Handle, a Warning notification kind), none of which this app needs yet, and runs build-native's macOS job on macos-15, since GitHub retires macos-14 on November 2.
Co-authored-by: SimonCropp <122666+SimonCropp@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves all seven PlatformHeads pins from 0.9.0 to 0.10.0:
uses:in.github/workflows/build-native.yml;GIT_TAGinnative/CMakeLists.txt;PlatformHeads,PlatformHeads.Core,PlatformHeads.LinuxandPlatformHeads.WindowsFormsinsrc/Directory.Packages.props;PlatformHeadspackage innative/swift/Package.swift.What 0.10.0 brings:
NotifyIconTrayadditions (SimonCropp/PlatformHeads#10):NotifyIconOptions.LeftClickOpensMenu,NotifyIconTray.HandleandTrayNotificationKind.Warning. All three are additions, and nothing here uses them yet. DiffEngine's Windows tray moved onto them in VerifyTests/DiffEngine#1013.build-native(SimonCropp/PlatformHeads#11): the reusable workflow's macOS job moves frommacos-14, which GitHub retires on November 2, tomacos-15. So the nextbuild-nativerun here builds the Swift library on macOS 15. In DiffEngine that run proposed rebuilt macOS binaries, which differed only by toolchain, and they went in alongside the pin move.HeadForm: a backing field replaced byfield, with no change to what it does.Tests. Locally on Windows, a Release build had no errors, and the whole solution passed: 1,595 tests, with 14 skipped and none failed.