Fixes to ctrl+click and middle-click behaviour of links in virtual content#54
Open
aaandreeew wants to merge 2 commits intoSignynt:mainfrom
Open
Fixes to ctrl+click and middle-click behaviour of links in virtual content#54aaandreeew wants to merge 2 commits intoSignynt:mainfrom
aaandreeew wants to merge 2 commits intoSignynt:mainfrom
Conversation
Fixes issue where ctrl+click or middle-click on a link while in reading view would cause the link to be opened twice in two new tabs.
Makes middle-click on external file links in both live preview and soure mode consistent between virtual content and default obsidian behaviour. This is a simple copy of the same code which only applied to ctrl+click on external file links.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #53.
Two changes:
I have not tested this PR, as I don't know how the build pipeline works. I have only tested by modifying files of the already installed plugin, which are processed JS files and not the source TS files.