Repository navigation
fix: keep job history pending until its data is ready - #42
Merged
sarthakagrawal927 merged 2 commits intoOct 22, 2026
Merged
Conversation
sarthakagrawal927
deleted the
agent/rolepatch-244-history-ready-20261022
branch
October 25, 2026 17:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While authentication resolved, a guest with saved jobs saw “No job history yet”, a zero count and empty filters before their actual history appeared. Keep the data-dependent panel in its existing skeleton style until authentication and guest storage are ready, with an accessible busy/status state and a stable Jobs header. Account data continues to use the server-provided records; this changes no storage, import or authentication behavior.
Keep the complete data-dependent region pending to avoid moving already-visible onboarding/history content as data arrives. Extract the shared header and loading component; ready layout and complexity baselines stay unchanged. Isolated Slow4G (150ms latency,200000B/s down,93750B/s up) + CPU4 browser checks cover empty, populated and completed-resume transitions at 390/768/1440: all nine measured layout-shift sums are 0, meeting the issue’s literal 0.05 ceiling. Error, in-page retry and revisit recover the existing synthetic record at all three widths without horizontal overflow.
The delayed-auth regression fails on the original public route and passes the patched route at 390/768/1440. The repository regression exercises saved history with both incomplete and completed resumes and checks the literal 0.05 layout-shift limit (six tests pass). The complexity gate passes without baseline relaxation. Typecheck, lint, unused checks, the dependency gate and the Astro landing build pass. The scoped dependency gate fix pins only Astro 7.2.8's affected Vite instance to 8.2.4; the existing accepted http-cache-semantics exception remains.
No production deployment. Production cold navigation still exceeds the 300 ms target; this patch does not claim to solve network timing or qualify private signed-in backend failure paths.
Related: sass-maker/saas-maker#244.