Repository navigation
Fix repeated deployments with duplicate SHA tags - #38
Merged
Merged
Conversation
20 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated manual deploys of one commit upload multiple Worker versions with the same source tag. Selecting that tag then fails as ambiguous. Deploy the exact UUID returned by the upload step, while retaining the full source SHA annotation. The parser fails closed on absent, malformed or multiple version IDs.
The existing OAuth tamper test also changed unused base64url bits and occasionally left the decoded signature unchanged. Its fixture now guarantees a different signature byte. Production auth logic is unchanged.
Validation: focused deploy/auth tests and full main CI passed at eb355d0. All six linked-checkout deploy gates passed. Approved deployments 38218537052 and 38218837704 both succeeded for that same SHA, including production smoke checks. Cloudflare independently confirmed each uploaded UUID at 100% traffic with the full source tag. Public home returned HTTP 200.