Repository navigation
Make resume onboarding direct and speed up public pricing and tools - #34
Merged
Merged
Conversation
…teraction loader Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ts, deferred PostHog and feedback widget) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… documents" This reverts commit fcf84ba.
sarthakagrawal927
marked this pull request as ready for review
October 13, 2026 21:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current reviewed candidate — October 14
Current head:
0703989cce1dba97694c4b775a330dea87005c7c. The exact recoveredd7414e1author history is preserved. Independent CodeVetter review found two lazy-CSS regressions: workspace sidebar/chart/radius aliases were omitted from application utilities, and the signed-in public account menu did not load its workspace portal palette on direct entry. Both are fixed; identical aliases now have one shared definition rather than duplicating workspace declarations.New browser regressions verify light sidebar/menu computed colors on direct public entry and workspace navigation, alongside guest menu/tool behavior. Current exact-head validation passes: full quality (762 tests, one existing skip; duplication improved), final Cloudflare build, eight desktop/mobile browser tests, and all required CI/docs/preview checks. Responsive renders at 390/768/1440 retained geometry with no horizontal overflow.
Exact-head Cloud qualification now passes the unchanged Lighthouse 12.8.2 median-of-three mobile workload: home1664.4416ms/performance100, pricing2448.9853ms/97, tools2423.8575ms/98. All nine runs have CLS0/BP100 and zero audit errors/warnings. One tools run is2532.2392ms; all samples are retained and the agreed median gate passes. Ten readiness tests and nine renders at390/768/1440 pass, with preserved pricing/tools geometry and byte-identical landing HTML. Settings/user agent match retained d7414e1; external HTTPS providers are blocked in this controlled workload. This is production-preview qualification, not live OAuth/provider or production acceptance. Root recomputed all three medians from the returned report JSON. Earlier measurements below remain historical. No production deployment was performed.
Historical qualification and retained source history
Passing Cloud candidate published — 2026-10-14
Recovered and fast-forward-pushed the four original author commits to
d7414e1711f91fae5a8502176108f5a66c645b5a(tree64d1edc927760099b9daab2dccf59cd7891068a2). All 48 transport chunks and complete bundle/gzip hashes matched before import; no source was reconstructed manually.The Cloud worker reports unchanged Lighthouse 12.8.2 mobile median-of-three gates passing:
/pricingLCP 2.188 s / performance 98;/tools2.453 s / performance 97;/1.540 s / performance 100. Every sample had CLS 0 and Best Practices 100. One Tools sample was 2.514 s; the required median passes by 47 ms. These are controlled preview measurements, not production acceptance.Changes remove duplicated inline CSS, split public/app utility delivery and lazily load account-only UI while preserving existing geometry, protected-account boundaries and author history. Cloud checks: 762 unit tests, one existing skip; full
cf:build; 34 browser regressions and renders at 390/768/1440. Fresh published-head CI and local independent review are in progress. No production deploy/release. Issues #32/#39 stay open until reviewed acceptance is complete.The section below records the superseded
ad337113fcandidate and its historical failing medians.Codex drafted; Claude measured. This PR remains a source candidate, not a release. The required sample-workload LCP gate (<=2.5 s) is still missed on
/pricingand/tools.The original PR publishes the guest resume-first and app-shell source slice tracked by RolePatch #32, alongside the still-open performance work in RolePatch #39. Neither issue is closed by this PR.
Latest source update (2026-10-13)
ad337113f12080027b017d466da094027bbf7c8d; source treec9f2d15abe4d7f72b62053505b6686ebcc2fe325. Five author commits were fast-forwarded onto the existing PR branch from prerequisite2a4277423dc53edb2eef3ed383a3ca3b6f4eb858./pricingand 2.937 s on/tools, both above 2.5 s. The performance threshold remains open; neither route is presented as passing.pnpm cf:buildpassed including 18/18 deploy-route checks and the OpenNext/Astro asset overlay. Recorded renders remain consistent at 390/768/1440 px. The recovered bundle's prerequisite, five-commit count, full bytes and source tree were verified before publication.pnpm quality/pnpm cf:buildon push and pull request, validation jobs, and the preview build. The production deploy job was skipped. No production deploy or release was performed.The performance threshold and any unmet production acceptance remain open under #39. This PR does not close #39 or publish a production release.