Skip to content

Make resume onboarding direct and speed up public pricing and tools - #34

Merged
sarthakagrawal927 merged 21 commits into
mainfrom
codex/lcp-pass3
Oct 13, 2026
Merged

sarthakagrawal927 merged 21 commits into
mainfrom
codex/lcp-pass3

Conversation

@sarthakagrawal927

@sarthakagrawal927 sarthakagrawal927 commented Oct 11, 2026 •

Copy link
Copy Markdown
Member

Current reviewed candidate — October 14

Current head: 0703989cce1dba97694c4b775a330dea87005c7c. The exact recovered d7414e1 author history is preserved. Independent CodeVetter review found two lazy-CSS regressions: workspace sidebar/chart/radius aliases were omitted from application utilities, and the signed-in public account menu did not load its workspace portal palette on direct entry. Both are fixed; identical aliases now have one shared definition rather than duplicating workspace declarations.

New browser regressions verify light sidebar/menu computed colors on direct public entry and workspace navigation, alongside guest menu/tool behavior. Current exact-head validation passes: full quality (762 tests, one existing skip; duplication improved), final Cloudflare build, eight desktop/mobile browser tests, and all required CI/docs/preview checks. Responsive renders at 390/768/1440 retained geometry with no horizontal overflow.

Exact-head Cloud qualification now passes the unchanged Lighthouse 12.8.2 median-of-three mobile workload: home1664.4416ms/performance100, pricing2448.9853ms/97, tools2423.8575ms/98. All nine runs have CLS0/BP100 and zero audit errors/warnings. One tools run is2532.2392ms; all samples are retained and the agreed median gate passes. Ten readiness tests and nine renders at390/768/1440 pass, with preserved pricing/tools geometry and byte-identical landing HTML. Settings/user agent match retained d7414e1; external HTTPS providers are blocked in this controlled workload. This is production-preview qualification, not live OAuth/provider or production acceptance. Root recomputed all three medians from the returned report JSON. Earlier measurements below remain historical. No production deployment was performed.


Historical qualification and retained source history

Passing Cloud candidate published — 2026-10-14

Recovered and fast-forward-pushed the four original author commits to d7414e1711f91fae5a8502176108f5a66c645b5a (tree 64d1edc927760099b9daab2dccf59cd7891068a2). All 48 transport chunks and complete bundle/gzip hashes matched before import; no source was reconstructed manually.

The Cloud worker reports unchanged Lighthouse 12.8.2 mobile median-of-three gates passing: /pricing LCP 2.188 s / performance 98; /tools 2.453 s / performance 97; / 1.540 s / performance 100. Every sample had CLS 0 and Best Practices 100. One Tools sample was 2.514 s; the required median passes by 47 ms. These are controlled preview measurements, not production acceptance.

Changes remove duplicated inline CSS, split public/app utility delivery and lazily load account-only UI while preserving existing geometry, protected-account boundaries and author history. Cloud checks: 762 unit tests, one existing skip; full cf:build; 34 browser regressions and renders at 390/768/1440. Fresh published-head CI and local independent review are in progress. No production deploy/release. Issues #32/#39 stay open until reviewed acceptance is complete.


The section below records the superseded ad337113f candidate and its historical failing medians.

Codex drafted; Claude measured. This PR remains a source candidate, not a release. The required sample-workload LCP gate (<=2.5 s) is still missed on /pricing and /tools.

The original PR publishes the guest resume-first and app-shell source slice tracked by RolePatch #32, alongside the still-open performance work in RolePatch #39. Neither issue is closed by this PR.

Latest source update (2026-10-13)

  • Published head: ad337113f12080027b017d466da094027bbf7c8d; source tree c9f2d15abe4d7f72b62053505b6686ebcc2fe325. Five author commits were fast-forwarded onto the existing PR branch from prerequisite 2a4277423dc53edb2eef3ed383a3ca3b6f4eb858.
  • The incremental slice reduces public heading-font transfer with a generated 700-weight WOFF2 subset and full-face fallback, preloads it only on Pricing and Tools, limits Tailwind scanning to the Next application source, and disables speculative prefetch for the six Tools cards. A focused E2E test covers the no-prefetch behavior and tool navigation. The Brotli experiment was reverted; no Brotli negotiation change remains in the final diff.
  • The final candidate sample workload reports LCP 2.929 s on /pricing and 2.937 s on /tools, both above 2.5 s. The performance threshold remains open; neither route is presented as passing.
  • The exact tree was validated in the Cloud bundle: 762 quality checks passed, 1 skipped; 26 browser tests; pnpm cf:build passed including 18/18 deploy-route checks and the OpenNext/Astro asset overlay. Recorded renders remain consistent at 390/768/1440 px. The recovered bundle's prerequisite, five-commit count, full bytes and source tree were verified before publication.
  • Fresh GitHub checks passed on this head: pnpm quality/pnpm cf:build on push and pull request, validation jobs, and the preview build. The production deploy job was skipped. No production deploy or release was performed.

The performance threshold and any unmet production acceptance remain open under #39. This PR does not close #39 or publish a production release.

sarthakagrawal927 and others added 2 commits October 11, 2026 23:37
…teraction loader

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ts, deferred PostHog and feedback widget)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@sarthakagrawal927 sarthakagrawal927 changed the title perf: rolepatch home/pricing/tools LCP (draft, gate not met) Make resume onboarding direct and speed up public pricing and tools Oct 13, 2026
@sarthakagrawal927
sarthakagrawal927 marked this pull request as ready for review October 13, 2026 21:11
@sarthakagrawal927
sarthakagrawal927 merged commit 748128a into main Oct 13, 2026
6 checks passed
@sarthakagrawal927
sarthakagrawal927 deleted the codex/lcp-pass3 branch October 16, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Finish the retained pricing and tools performance PR

1 participant