Skip to content

Keep visibility from bare sections in exported gem RBIs #2751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dduugg wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Open

Keep visibility from bare sections in exported gem RBIs #2751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/tapioca/gemfile.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,8 @@ def exported_rbi_tree

exported_rbi_files.each do |file|
rbi = RBI::Parser.parse_file(file)
# Merging drops standalone `private`/`protected` nodes, so move their visibility onto each method first
rbi.flatten_visibilities!
rewriter.merge(rbi)
end

Expand Down
8 changes: 8 additions & 0 deletions spec/tapioca/cli/gem_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,10 @@ def self.foo(a = T.unsafe(nil), b: T.unsafe(nil), **opts); end
write!("rbi/foo/bar.rbi", <<~RBI)
module Foo
def foo; end

private

def baz; end
end
RBI

Expand Down Expand Up @@ -362,6 +366,10 @@ def bar; end
module Foo
def foo; end

private

def baz; end

class << self
sig { params(a: String, b: Integer, opts: T.untyped).void }
def foo(a = T.unsafe(nil), b: T.unsafe(nil), **opts); end
Expand Down
Loading