Avoid errors for empty DSL matches in add-on mode#2675
Open
zeeshankhan-05 wants to merge 2 commits into
Open
Conversation
When the LSP requests generation for an existing constant with no processable DSL, return quietly instead of raising Tapioca::Error. Co-authored-by: Cursor <cursoragent@cursor.com>
amomchilov
reviewed
Jul 17, 2026
| end) | ||
| break if Process.clock_gettime(Process::CLOCK_MONOTONIC) >= deadline | ||
|
|
||
| sleep(0.1) |
Contributor
There was a problem hiding this comment.
This is guaranteed to be flakey if the GitHub action runner is overcommited. Is there some other wait we could do?
Contributor
Author
There was a problem hiding this comment.
Ah, you're right. I'll replace the timed poll with a wait on the dsl request's work-done-progress "end" event. So since the error log is always sent before "end", then blocking until "end" makes the check deterministic. I'll enable window.workDoneProgress on the test client
Contributor
Author
There was a problem hiding this comment.
Now waiting on the dsl work-done-progress "end" event instead of a timed poll. Errors are always logged before "end", so the check is deterministic.
Contributor
|
Good improvement though! |
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tapioca::Errorin the editorFixes #2348
Test plan
Fooclass with no processable DSL