ActiveRecord integrations now using transactions respecting "use_transactions" config

[shuhaowu]

Right now state_machine is somewhat abandoned it seems like, given the fact that it is last updated May 2013.

The bug: pluginaweek#264
The fix: pluginaweek#255 (included here).

@camilo, @jnormore for review? (Anyone else?)

(Sorry for the mail spam, created a PR against the wrong base repository in the beginning)

[arthurnn]

I force pushed master to use 1.2.0 version + one cherry-picked commit... can you rebase this PR against latest master, and we move from there?

thanks @shuhaowu

[shuhaowu]

Done.

[shuhaos-mbp-2:~/shopify/state_machine]$ bundle exec rake test
/usr/local/Cellar/ruby/2.1.5/bin/ruby -I"lib:lib" -I"/usr/local/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib" "/usr/local/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/rake_test_loader.rb" "test/functional/state_machine_test.rb" "test/unit/assertions_test.rb" "test/unit/branch_test.rb" "test/unit/callback_test.rb" "test/unit/error_test.rb" "test/unit/eval_helpers_test.rb" "test/unit/event_collection_test.rb" "test/unit/event_test.rb" "test/unit/graph_test.rb" "test/unit/helper_module_test.rb" "test/unit/integrations_test.rb" "test/unit/invalid_event_test.rb" "test/unit/invalid_parallel_transition_test.rb" "test/unit/invalid_transition_test.rb" "test/unit/machine_collection_test.rb" "test/unit/machine_test.rb" "test/unit/matcher_helpers_test.rb" "test/unit/matcher_test.rb" "test/unit/node_collection_test.rb" "test/unit/path_collection_test.rb" "test/unit/path_test.rb" "test/unit/state_collection_test.rb" "test/unit/state_context_test.rb" "test/unit/state_machine_test.rb" "test/unit/state_test.rb" "test/unit/transition_collection_test.rb" "test/unit/transition_test.rb" "test/unit/integrations/base_test.rb"
Skipping GraphViz StateMachine::Branch tests. `gem install ruby-graphviz` >= v0.9.17 and try again.
Skipping GraphViz StateMachine::Event tests. `gem install ruby-graphviz` >= v0.9.17 and try again.
Skipping GraphViz StateMachine::Graph tests. `gem install ruby-graphviz` >= v0.9.17 and try again.
Skipping GraphViz StateMachine::Machine tests. `gem install ruby-graphviz` >= v0.9.17 and try again.
Skipping GraphViz StateMachine::State tests. `gem install ruby-graphviz` >= v0.9.17 and try again.
Run options:

# Running tests:

Finished tests in 2.655971s, 665.2934 tests/s, 826.4397 assertions/s.
1767 tests, 2195 assertions, 0 failures, 0 errors, 0 skips

ruby -v: ruby 2.1.5p273 (2014-11-13 revision 48405) [x86_64-darwin13.0]

However, We should update this separately as more 👀 maybe required. @fw42 is working on removing all the http calls from transactions so maybe he can take a look?

[arthurnn]

this looks good to me.. Diff is only if flag use_transactions is false.. Do we have that as false anyways?

[shuhaowu]

I don't think so. So I suppose merging this shouldn't have any unintended side effects.

However, unless we mean it, we really should have use_transactions as false.