Skip to content

Remove oj dependency to restore JRuby support - #1462

Open
najibna wants to merge 2 commits into
Shopify:mainfrom
najibna:fix/remove-oj-jruby-1461
Open

najibna wants to merge 2 commits into
Shopify:mainfrom
najibna:fix/remove-oj-jruby-1461

Conversation

@najibna

@najibna najibna commented Sep 20, 2026

Copy link
Copy Markdown

Description

Fixes #1461

oj is an unused native C-extension dependency. It cannot be installed on JRuby and is not called at runtime, so it only blocks JRuby users.

This PR removes it from the gemspec, requires, lockfile, and generated RBI files.

How has this been tested?

  • bundle exec rake test — 342 runs, 0 failures
  • bundle exec srb tc — no errors

Checklist:

  • My commit message follow the pattern described in here
  • I have performed a self-review of my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the project documentation.
  • I have added a changelog line.

@github-actions github-actions Bot added cla-needed devtools-gardener Post the issue or PR to Slack for the gardener labels Sep 20, 2026
@najibna

najibna commented Sep 20, 2026

Copy link
Copy Markdown
Author

I have signed the CLA!

@najibna

najibna commented Sep 20, 2026

Copy link
Copy Markdown
Author

Ready for review.

CLA is signed. Tests and srb tc pass. Changelog is updated. No docs change needed for this dependency removal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devtools-gardener Post the issue or PR to Slack for the gardener

Projects

None yet

Development

Successfully merging this pull request may close these issues.

oj dependency breaks support for JRuby

1 participant