Add localfs and localfsMap to the debugger configuration schema#4121
Open
eyupcanakman wants to merge 1 commit into
Open
Add localfs and localfsMap to the debugger configuration schema#4121eyupcanakman wants to merge 1 commit into
eyupcanakman wants to merge 1 commit into
Conversation
The ruby_lsp debugger forwards launch configurations to the Ruby debug gem, which reads localfs and localfsMap, but they were never declared in the package.json schema, so VS Code flagged them as not allowed. Declare both under launch and attach. Closes Shopify#3597
Author
|
I have signed the CLA! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #3597. Setting
localfsMap(orlocalfs) in aruby_lspdebug configuration shows a "Property not allowed" warning in VS Code, even though the option works. The extension forwards the launch configuration to the Rubydebuggem, which reads these keys, but they were never declared in the debugger schema, so VS Code treated them as unknown.Implementation
Declare
localfsandlocalfsMapunder bothlaunchandattachin the debuggerconfigurationAttributes. The gem's DAP server reads both keys for both request types inserver_dap.rb, so VS Code no longer flags them.Automated Tests
None. The new entries are declarations in the
contributes.debuggersschema inpackage.json, which VS Code validates againstlaunch.jsonat runtime. The extension does not have tests covering itspackage.jsoncontributions.Manual Tests
launch.jsonwith aruby_lspattach configuration containing"localfsMap": "/remote:/local"(or"localfs": true).main, VS Code flags the property with "Property localfsMap not allowed".