Avoid indenting after endless method definition

[vinistock]

Motivation

Closes #3997

The automatic indentation rules that are bundled in VS Code don't account for endless method definitions and end up advancing the indentation when you break the line (which isn't what you'd expect).

This PR adds our own indentation rules to validate the fix first. Once we know this works correctly, we can contribute the improvement to VS Code and get rid of this.

Implementation

The rules become more complicated because we now need a negative lookahead that can catch and endless method definition without confusing it with a setter name. Using a setter name with an endless method definition is actually a syntax error, but we don't want to indent anyway.

Example:

# No indent
def foo = 42
def self.foo = 42
def Foo.foo = 42
def foo=(foo) = 42 # invalid, but we don't want to indent
def self.foo=(foo) = 42 # invalid, but we don't want to indent
def Foo.foo=(foo) = 42 # invalid, but we don't want to indent

# Indent
def foo
def self.foo
def Foo.foo
def foo=(foo)
def self.foo=(foo)
def Foo.foo=(foo)

[vinistock]

• Avoid indenting after endless method definition #4041 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add the label graphite-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.