Integrate with Active Record#48
Open
seanpdoyle wants to merge 1 commit intoShopify:active-model-collection-attributefrom
Open
Integrate with Active Record#48seanpdoyle wants to merge 1 commit intoShopify:active-model-collection-attributefrom
seanpdoyle wants to merge 1 commit intoShopify:active-model-collection-attributefrom
Conversation
First, register the `ActiveModel::Type::Collection` with `ActiveRecord::Type`. Next, add test coverage for writing to and reading from a `TEXT` and `JSON` column.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
The rails#51421 PR was opened as a copy of a prior PR that was closed. In its current state, it lacks test coverage for Active Record-side support. This PR aims to fill in the gaps in order to make rails#51421 viable for merge.
Detail
First, register the
ActiveModel::Type::CollectionwithActiveRecord::Type.Next, add test coverage for writing to and reading from a
TEXTandJSONcolumn.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]