Improved the card design's box shadow to be visible from all directions. #1338
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaibadash
force-pushed
the
fix/card_border_design
branch
from
18bc8e9 to
cf22986
Compare
adrianna-chang-shopify
approved these changes
Jan 6, 2026
Contributor
adrianna-chang-shopify
left a comment
adrianna-chang-shopify
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Contributor
|
Hey @kaibadash , CI seems to be stalling, presumably because we made some changes to the testing matrix. Can you rebase and push again? Thanks! |
Changed box-shadow to include a uniform shadow around the box with a subtle downward emphasis for a more natural appearance.
kaibadash
force-pushed
the
fix/card_border_design
branch
from
cf22986 to
6e2f557
Compare
Contributor
Author
|
@adrianna-chang-shopify Thank you for your review! I did it. Could you run the workflow ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the card design's box shadow to be visible from all directions.
Adjusted the box shadow to fix the issue where the top border of the card design was difficult to see.
before
The top border is barely visible on my PC(macbook pro 16 inch 2023).
after
Another idea
I think setting a background color is a good idea too. Which one do you prefer?