[Refactor] Simplify parseEnvNumber helper in environment module - #8519
[Refactor] Simplify parseEnvNumber helper in environment module#8519gonzaloriestra wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
Fixes #0000
In
packages/cli-kit/src/public/node/environment.ts,parseEnvNumbercalledNumber(value)twice whenever a valid numeric string was provided and used the legacy globalisNaN()function instead of standardNumber.isNaN().WHAT is this pull request doing?
Refactors
parseEnvNumberinenvironment.tsto:undefinedfor empty/falsy inputsNumber(value)onceNumber.isNaNto check for invalid numbersHow to manually test your changes?
CI
Post-release steps
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 12271033484687374892 started by @gonzaloriestra