Add static frame-ancestors check to App Doctor - #8500
Conversation
jplhomer
left a comment
There was a problem hiding this comment.
Couple small questions!
|
Good questions. |
dmerand
left a comment
There was a problem hiding this comment.
Again, approved from the overall lens of CLI command membership. My agents had a couple of notes about the implementation that may be worth considering.
Assisted-By: devx/0434e4da-7c55-4ded-87bd-400bf4d8a927
Assisted-By: devx/0434e4da-7c55-4ded-87bd-400bf4d8a927
Assisted-By: devx/0434e4da-7c55-4ded-87bd-400bf4d8a927
Assisted-By: devx/0434e4da-7c55-4ded-87bd-400bf4d8a927
Assisted-By: devx/0434e4da-7c55-4ded-87bd-400bf4d8a927
Assisted-By: devx/0434e4da-7c55-4ded-87bd-400bf4d8a927
eede6ca to
f84268b
Compare
Assisted-By: devx/3ac90870-9844-4116-81bc-cd8883bd74f9
WHY are these changes introduced?
STATIC_FRAME_ANCESTORSalready exists as an App Doctor product ID in the agentic pack, but the deterministic engine had no narrow implementation for the literal cases it can prove safely.WHAT is this pull request doing?
STATIC_FRAME_ANCESTORSrunner for embedded admin apps only.embedded_appcapability derived from rootembedded = trueinshopify.app.toml, separate from theme app-embed blocks.frame-ancestorstokens insideContent-Security-Policytext.Verification
pnpm exec vitest run packages/app/src/cli/services/app-doctor-engine/tests/deterministic-rules.test.ts packages/app/src/cli/services/app-doctor-engine/tests/scan-contract.test.ts packages/app/src/cli/services/app-doctor-engine/tests/trace.test.ts packages/app/src/cli/services/app-doctor-json.test.ts packages/app/src/cli/services/doctor-output.test.ts packages/app/src/cli/services/doctor.test.tspnpm --filter @shopify/app type-checkpnpm --filter @shopify/app lint