Add new App Doctor agent checks - #8498
Merged
Merged
Conversation
dmerand
approved these changes
Sep 8, 2026
Assisted-By: devx/0434e4da-7c55-4ded-87bd-400bf4d8a927
lopez-mar
force-pushed
the
app-doctor-new-agent-checks
branch
from
September 9, 2026 14:03
0dc4ffe to
f85d3e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
App Doctor's current agentic pack does not have dedicated checks for lifecycle/replay failures, dependency reachability, or upload-to-active-preview execution paths. These are separate from the prompt refinements in #8495 and deserve their own review surface.
WHAT is this pull request doing?
Adds three new App Doctor agent checks:
SESSION_LIFECYCLE_AND_REPLAYDEPENDENCY_REACHABILITYACTIVE_UPLOADS_AND_PRIVILEGED_PREVIEWSAlso registers the new stable IDs in the App Doctor catalog, regenerates the embedded prompt bundle, updates prompt-loading tests from 31 to 34 checks, and adds a patch changeset.
The active-upload prompt is intentionally bounded to complete upload-to-active-render paths and does not report storage/header hygiene alone.
How to test your changes?
pnpm --filter @shopify/app generate:app-doctor-checks pnpm exec vitest run packages/app/src/cli/services/app-doctor-engine/tests/checks.test.ts packages/app/src/cli/services/app-doctor-engine/tests/registry.test.ts packages/app/src/cli/services/app-doctor-engine/tests/scan-contract.test.ts packages/app/src/cli/services/app-doctor-instructions.test.ts packages/app/src/cli/services/app-doctor-api.test.ts pnpm --filter @shopify/app type-check pnpm --filter @shopify/app lintPost-release steps
After #8495 merges, rebase this branch onto updated
mainand regeneratepackages/app/src/cli/services/app-doctor-engine/checks/embedded.tsbefore merging so the generated prompt bundle and check counts reflect both PRs.Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add