Improve PR instructions for agents - #8412
Merged
Merged
Conversation
gonzaloriestra
force-pushed
the
improve-pr-instructions
branch
from
August 31, 2026 12:58
7446487 to
c2d9c12
Compare
amcaplan
approved these changes
Sep 9, 2026
|
|
||
| <!-- | ||
| Please, provide steps for the reviewer to test your changes locally. | ||
| Do not include here commands to run tests or other checks, automated CI will run them. |
Contributor
There was a problem hiding this comment.
Excellent point. This always bothers me!
|
|
||
| - Use GitHub stacks for multiple dependant PRs | ||
| - Follow the template from .github/PULL_REQUEST_TEMPLATE.md | ||
| - Be concise |
Contributor
There was a problem hiding this comment.
This one line might be a bit too concise - maybe some "focus on X, not Y" might help.
Still an improvement, I guess we'll see if it's enough.
But I think saying to keep it short is more likely to lead to trying to squeeze more meaning into fewer words rather than really evaluating what needs to be present.
Contributor
There was a problem hiding this comment.
I second this one. Examples might be helpful here as well.
Contributor
Author
There was a problem hiding this comment.
Updated! Better now?
dmerand
approved these changes
Sep 9, 2026
|
|
||
| - Use GitHub stacks for multiple dependant PRs | ||
| - Follow the template from .github/PULL_REQUEST_TEMPLATE.md | ||
| - Be concise |
Contributor
There was a problem hiding this comment.
I second this one. Examples might be helpful here as well.
gonzaloriestra
force-pushed
the
improve-pr-instructions
branch
from
September 9, 2026 14:47
d7de83b to
4c77815
Compare
gonzaloriestra
enabled auto-merge
September 9, 2026 14:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
PRs created by agents are usually too verbose and inconsistent.
WHAT is this pull request doing?
Improve AGENTS.md instructions to follow the template and be more consistent
How to test your changes?
Merge and create PRs
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add