Skip to content

[Tests] Add unit tests for custom-oclif-loader ShopifyConfig#8169

Draft
gonzaloriestra wants to merge 1 commit into
mainfrom
tests-custom-oclif-loader-17108149934386460414
Draft

[Tests] Add unit tests for custom-oclif-loader ShopifyConfig#8169
gonzaloriestra wants to merge 1 commit into
mainfrom
tests-custom-oclif-loader-17108149934386460414

Conversation

@gonzaloriestra

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The file packages/cli-kit/src/public/node/custom-oclif-loader.ts contains the custom ShopifyConfig oclif Config class which lazy loads commands. This logic previously lacked dedicated unit test coverage.

WHAT is this pull request doing?

This pull request introduces comprehensive unit tests in packages/cli-kit/src/public/node/custom-oclif-loader.test.ts to cover ShopifyConfig. The tests verify the following:

  • Falling back to super.runCommand when no lazy command loader is configured.
  • Falling back to super.runCommand when a command is not found.
  • Falling back to super.runCommand when lazy loader returns undefined.
  • Successful lazy loading, confirming that command class properties are set, Hooks are invoked with correct args, and the command runs and returns the result.

How to test your changes?

CI

Post-release steps

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 17108149934386460414 started by @gonzaloriestra

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant