chore(deps): prune stale knip config entries#8165
Draft
EvilGenius13 wants to merge 1 commit into
Draft
Conversation
- Remove 8 obsolete `ignoreDependencies` entries now genuinely used (direct imports, generated GraphQL clients, or @testing-library/react peer deps) across app, cli-kit, store, organizations, ui-extensions-server-kit, ui-extensions-test-utils. - Remove 5 dead/redundant `entry` patterns: non-matching globs (docs-shopify.dev/**/*.ts, docs/api/cli-kit/**/*.js, plugin-cloudflare commands/hooks) and knip built-in defaults (vite.config.ts, graphql.config.ts). - Remove 1 redundant `ignore` (packages/e2e/scripts/** — packages/e2e is already in ignoreWorkspaces). - No behavior change: knip still exits 0 with zero findings; config hints drop 16 -> 2 (remaining 2 are pre-existing ./assets/** packaging refs, untouched).
github-actions
Bot
added
the
no-changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Prunes 14 stale entries from the inline
knipconfig in rootpackage.json. Pure config cleanup — no source or behavior changes.Why
pnpm knipwas emitting 16 configuration hints flagging its own config as stale. All 14 targeted entries were verified obsolete:ignoreDependencieswere suppressing nothing — each dep is now genuinely used (direct imports, generated GraphQL client files, or@testing-library/reactpeer deps). Since knip'sdependenciesrule iserror, a truly-unused dep would have failed the run; it stays green.entrypatterns were dead: 3 match zero files (docs-shopify.dev/**/*.ts,docs/api/cli-kit/**/*.js, plugin-cloudflarecommands/hooks) and 2 duplicate knip's built-in defaults (vite.config.ts,graphql.config.ts).ignore(packages/e2e/scripts/**) nested inside the already-ignoredpackages/e2eworkspace.