Skip to content

Make shopify-dev-tools self-contained #8153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
durga256 wants to merge 1 commit into
base: move-shopify-dev-tools
Choose a base branch
from
Draft

Make shopify-dev-tools self-contained #8153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions packages/shopify-dev-tools/scripts/generate-agent-skills.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,30 +61,28 @@ const SCHEMA_DATA_DIR = join(PACKAGE_ROOT, "src/data");
const SCRIPTS_SRC_DIR = join(PACKAGE_ROOT, "src/agent-skills/scripts");
const SKILL_ASSETS_DIR = join(PACKAGE_ROOT, "src/skill-assets");
const DEFAULT_AGENT_SKILLS_OUT_DIR = join(MONOREPO_ROOT, "packages", "skills");
const PLUGIN_HOOKS_SCRIPTS_DIR = join(
MONOREPO_ROOT,
"packages",
"plugins",
const SKILL_TELEMETRY_HOOKS_DIR = join(
PACKAGE_ROOT,
"src",
"agent-skills",
"hooks",
"scripts",
);

// Files copied verbatim into each generated skill's `scripts/` directory so
// the skill-frontmatter `hooks:` block (Claude Code only — see
// `skillTelemetryHookBlock` in src/instructions/skill-blocks.ts) can resolve
// `./scripts/track-telemetry.sh` on standalone installs that don't have the
// plugin's hooks tree available.
// `./scripts/track-telemetry.sh` on standalone installs.
const SKILL_TELEMETRY_HOOK_FILES = [
"track-telemetry.sh",
"track-telemetry.ps1",
] as const;

function copySkillTelemetryHook(scriptsDir: string): void {
for (const file of SKILL_TELEMETRY_HOOK_FILES) {
const src = join(PLUGIN_HOOKS_SCRIPTS_DIR, file);
const src = join(SKILL_TELEMETRY_HOOKS_DIR, file);
if (!existsSync(src)) {
throw new Error(
`Expected ${src} to exist. The skill-frontmatter telemetry hook is bundled into each generated skill from packages/plugins/hooks/scripts/.`,
`Expected ${src} to exist. The skill-frontmatter telemetry hook is bundled into each generated skill from shopify-dev-tools.`,
);
}
const dest = join(scriptsDir, file);
Expand Down
Loading
Loading