Fix error for running build when there is multiple admin links and ui extensions#7347
Draft
vividviolet wants to merge 1 commit intomainfrom
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
When wrapper helpers forward optional fields as explicit
undefined, thoseundefinedvalues were shadowing the computed defaults increateExtensionSpecification. This meant fields likeexperience,uidStrategy, andbuildConfigcould end up asundefinedinstead of their intended default values.WHAT is this pull request doing?
Before merging the caller-supplied
specobject into the defaults, explicitundefinedvalues are stripped fromspecusingpickBy. This ensures that defaults are preserved when optional fields are forwarded asundefinedby wrapper helpers, rather than being overwritten.A regression test is added to verify that explicitly passing
undefinedforexperience,uidStrategy,buildConfig, andclientStepsstill results in the correct defaults being applied.How to test your changes?
Run the integration tests for the extension specification:
The new test case
does not let explicit-undefined spec keys shadow the computed defaultsshould pass.Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add