Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
When users press Ctrl+C to exit
shopify theme dev, the process immediately callsprocess.exit(), terminating before the oclif post-run hook can send analytics events. This means we lose telemetry data for theme dev sessions.The
backgroundJobPromisewas originally typed asPromise<never>because it was only meant to reject on error (never resolve). This meant there was no mechanism to gracefully complete the promise chain on user-initiated exit.WHAT is this pull request doing?
Fixes analytics not being sent when exiting
theme devvia Ctrl+C by implementing graceful shutdown:process.exit()directlypostRunHookHasCompleted()with a 5-second timeoutprocess.exit(0)only after analytics have been sent (or timeout reached)How to test your changes?
shopify theme devagainst a development storeChecklist
pnpm changeset add