Open
Conversation
db9717d to
c5cf362
Compare
7e01abd to
acc94a4
Compare
4 tasks
603ab33 to
4ef8ece
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/private/node/session.d.ts@@ -63,14 +63,14 @@ export interface OAuthSession {
}
type AuthMethod = 'partners_token' | 'device_auth' | 'theme_access_token' | 'custom_app_token' | 'none';
/**
- * Retrieves a stable user identifier for analytics, or if none applies.
+ * Retrieves the user ID from the current session or returns 'unknown' if not found.
*
- * Evaluation order:
- * 1. If an app automation token or theme token is used, returns a deterministic UUID
- * derived from that secret.
- * 2. Otherwise, if was called (e.g. after OAuth), returns that value.
- * 3. Otherwise, if a persisted CLI session id is available, returns it.
- * 4. Otherwise returns .
+ * This function performs the following steps:
+ * 1. Checks for a cached user ID in memory (obtained in the current run).
+ * 2. Attempts to fetch it from the local storage (from a previous auth session).
+ * 3. Checks if a custom token was used (either as a theme password or partners token).
+ * 4. If a custom token is present in the environment, generates a UUID and uses it as userId.
+ * 5. If after all this we don't have a userId, then reports as 'unknown'.
*
* @returns A Promise that resolves to the user ID as a string.
*/
packages/cli-kit/dist/public/node/ui.d.ts@@ -328,6 +328,7 @@ interface RenderTasksOptions {
/**
* Runs async tasks and displays their progress to the console.
* @example
+ * ▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
* Installing dependencies ...
*/
export declare function renderTasks<TContext>(tasks: Task<TContext>[], { renderOptions, noProgressBar }?: RenderTasksOptions): Promise<TContext>;
@@ -345,6 +346,7 @@ export interface RenderSingleTaskOptions<T> {
* @param options.renderOptions - Optional render configuration
* @returns The result of the task
* @example
+ * ▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
* Loading app ...
*/
export declare function renderSingleTask<T>({ title, task, onAbort, renderOptions, }: RenderSingleTaskOptions<T>): Promise<T>;
|
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
4ef8ece to
8810eb4
Compare
acc94a4 to
81fd9c2
Compare
8810eb4 to
d5fe541
Compare
81fd9c2 to
9a6b6b8
Compare
Move existing store:auth and store:execute commands and their services into a dedicated @shopify/store package, following the same pattern as @shopify/theme. This prepares the store namespace for new commands like store create dev. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… utilities Creates a standalone package for organization fetching and selection, calling the Business Platform Destinations API directly. Includes GraphQL codegen pipeline, fetchOrganizations (with GID decoding), selectOrganizationPrompt (auto-select for single org, duplicate name disambiguation), and selectOrg helper. Wires packages/app to use @Shopify/organizations for org fetching in AppManagementClient.organizations() and for the org selection prompt, eliminating duplicated Destinations API and prompt logic. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
d5fe541 to
ee242f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
@shopify/organizationspackage with org listing and selection utilitiesfetchOrganizations(with base64 GID decoding),selectOrganizationPrompt(auto-selects single org), andselectOrghelper@shopify/storeStack: PR 2 of 3 — depends on #7330, #7332 adds
store create devTest plan
pnpm nx build organizationspassespnpm nx type-check organizationspassescd packages/organizations && pnpm vitest run— 10/10 tests passcd packages/store && pnpm vitest run— no regressions🤖 Generated with Claude Code