Make Homebrew versioned formula generation dynamic#7310
Open
alfonso-noriega wants to merge 2 commits intomainfrom
Open
Make Homebrew versioned formula generation dynamic#7310alfonso-noriega wants to merge 2 commits intomainfrom
alfonso-noriega wants to merge 2 commits intomainfrom
Conversation
This was referenced Apr 15, 2026
Merged
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
isaacroldan
reviewed
Apr 16, 2026
|
|
||
| async function renderVersionedFormula(majorVersion, variables) { | ||
| const engine = new Liquid({root: packagingDirectory}) | ||
| const templatePath = path.join(packagingDirectory, "stable/src/shopify-cli.rb.liquid") |
Contributor
There was a problem hiding this comment.
I see that liquid file still has references to version 3
like
if formulaVersion != '3
Do we need to update that?
Contributor
Author
There was a problem hiding this comment.
updated already in the original PR. My question here would be whether we really want to this and keep generating formulas for previous versions or not.
Instead of a hardcoded majorVersion === 3 guard, generate the current major's versioned formula (e.g. shopify-cli@3.rb, shopify-cli@4.rb) dynamically on every stable release using the shared template. When we ship a new major, the previous major's formula in homebrew-shopify naturally freezes at its last release since we stop updating it — no manual intervention needed.
…any major version
alfonso-noriega
force-pushed
the
prepare-semver-support
branch
from
51b313f to
c24f37c
Compare
alfonso-noriega
force-pushed
the
homebrew-versioned-formulas
branch
from
a573648 to
2ac3237
Compare
isaacroldan
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to test your changes?
Post-release steps
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add