Migrate CheckoutErrorRequest to CheckoutErrorEvent #493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kieran-osgood-shopify
changed the title
kieran-osgood-shopify
force-pushed
the
prototype-development/issue-139-checkout.error
branch
from
d962027 to
a513e09
Compare
| /// Issued when the storefront configuration has caused an error. | ||
| /// Note that the Checkout Sheet Kit only supports stores migrated for extensibility. | ||
| case configurationError(message: String, code: CheckoutErrorCode, recoverable: Bool = false) | ||
| case misconfiguration(message: String, code: ErrorCode, recoverable: Bool = false) |
Contributor
Author
There was a problem hiding this comment.
Proposal: rename configuration -> misconfiguration
Felt closer aligned to the naming of "expired" and "unavailable" (the target of the noun is whats happened?)
.sdk still feels like an outlier in that sense though
Contributor
There was a problem hiding this comment.
.sdk → .internal maybe?
misconfiguration looks good
| /// | ||
| /// Every event has a "recoverable" property that indicates this error may be recoverable when retried in a fallback browser experience | ||
| /// This may have a degraded experience, implement CheckoutDelegate.shouldRecoverFromError to opt out | ||
| public enum CheckoutError: Error { |
Contributor
Author
There was a problem hiding this comment.
As this error class is CheckoutError I thought it may make sense to remove the repeated/inconsistent "checkout" and "error" in the cases
markmur
reviewed
Dec 15, 2025
Comment on lines
+82
to
+84
| /// unavailable: recoverable:true | ||
| case killswitchEnabled = "KILLSWITCH_ENABLED" | ||
| case unrecoverableFailure = "UNRECOVERABLE_FAILURE" |
Contributor
There was a problem hiding this comment.
recoverable: true here seems wrong?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Before you merge
Important
Releasing a new version of the kit?
podspecfile.Releasing a new major version?
Tip
See the Contributing documentation for instructions on how to publish a new version of the library.