Remove the standalone accelerated checkouts Swift sample - #747
Draft
kieran-osgood-shopify wants to merge 3 commits into
Draft
Remove the standalone accelerated checkouts Swift sample#747kieran-osgood-shopify wants to merge 3 commits into
kieran-osgood-shopify wants to merge 3 commits into
Conversation
Consolidate accelerated checkout configuration in CheckoutKitSwiftDemo, remove the obsolete samples workspace, and point Swift tooling directly at the generated demo project. Assisted-By: devx/5dcdaea4-b0c1-4726-9f3c-66b15b5496f4
Assisted-By: devx/5dcdaea4-b0c1-4726-9f3c-66b15b5496f4
Assisted-By: devx/5dcdaea4-b0c1-4726-9f3c-66b15b5496f4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
The standalone accelerated checkouts Swift sample duplicated the main demo and required a shared Xcode workspace even though only one maintained demo is needed.
CheckoutKitSwiftDemo.ShopifyAcceleratedCheckoutsAppand the obsoleteSamples.xcworkspace.CheckoutKitSwiftDemo.xcodeproj.CheckoutKitSwiftDemo/Package.resolvedand copies them into the generated project.Previously,
dev swift openopened the shared samples workspace and accelerated checkout configuration lived in the separate app. It now opens the consolidated demo project directly.How to test
GIVEN this PR is checked out and
dev uphas generated the Swift sample configurationWHEN the reviewer runs
dev swift openTHEN Xcode should open
CheckoutKitSwiftDemo.xcodeprojdirectly, and theCheckoutKitSwiftDemoscheme should build and run withoutSamples.xcworkspaceGIVEN
CheckoutKitSwiftDemois running on iOS 16 or newer with valid Storefront and Apple Pay merchant configurationWHEN the reviewer opens Settings, selects Configure Accelerated Checkouts, and changes the accelerated checkout language, contact requirements, buyer email or phone, supported shipping countries, and log level
THEN a dedicated Accelerated Checkouts screen should be pushed onto the navigation stack, and those choices should remain selected after leaving and reopening the screen and should be applied to accelerated checkout controls in the product and cart flows without a missing-configuration error
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/README.md(major version only)Releasing a new Embedded Checkout Protocol version?
embeddedCheckoutProtocolAndroidinplatforms/android/gradle/libs.versions.tomlprotocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.apiif the public API changedReleasing a new Android version?
checkoutKitAndroidinplatforms/android/gradle/libs.versions.tomlplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.