Fix local E2E selection on Bash 3.2 - #738
Open
kieran-osgood-shopify wants to merge 1 commit into
Open
Conversation
Assisted-By: devx/287431b4-703c-4ecb-8a31-f393b6e10436
Install this buildOpen Tophat, select your target device, then click Install. Links open on the Mac running Tophat.
Checkout Kit E2E results
FailuresCaution These E2E checks are not yet required, so they do not block merging — but a failure may still indicate a real issue to resolve before merging.
Android — kotlin-android
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Fix local E2E test selection under macOS Bash 3.2 by avoiding empty-array expansion with
set -u.This addresses the positional-file and tag-only failures reported after #705 merged.
What changed
How to test
GIVEN a Mac whose
/bin/bash --versionreports Bash 3.2 and a booted iOS simulatorWHEN the reviewer runs
/bin/bash ./e2e/scripts/run_local_e2e swift-ios tests/shared/launch-smoke.yamlTHEN the Swift sample should build and the
Launch smokeflow should pass instead of exiting withRESOLVED_TEST_FILES[@]: unbound variableGIVEN a Mac whose
/bin/bash --versionreports Bash 3.2 and a booted iOS simulatorWHEN the reviewer runs
/bin/bash ./e2e/scripts/run_local_e2e swift-ios --tags smokeTHEN all enabled Swift smoke flows should pass instead of exiting while expanding an empty test-file array