[ReactNative] Rename oncancel to ondismiss in swift and android#483
Open
kiftio wants to merge 1 commit into
Open
[ReactNative] Rename oncancel to ondismiss in swift and android#483kiftio wants to merge 1 commit into
kiftio wants to merge 1 commit into
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
11 tasks
kiftio
force-pushed
the
07-16-rename_oncancel_to_ondismiss_in_swift_and_android
branch
from
July 16, 2026 11:21
b341fdf to
39006d4
Compare
kiftio
force-pushed
the
use_onDismiss_rather_than_onCancel_in_react-native
branch
from
July 16, 2026 11:21
f1316ee to
19a21c1
Compare
kiftio
changed the base branch from
07-16-rename_oncancel_to_ondismiss_in_swift_and_android
to
graphite-base/483
July 16, 2026 12:09
kiftio
force-pushed
the
use_onDismiss_rather_than_onCancel_in_react-native
branch
from
July 16, 2026 12:09
19a21c1 to
809c8b0
Compare
kiftio
changed the base branch from
graphite-base/483
to
07-16-updates_accelerated_checkouts_to_use_ondismiss
July 16, 2026 12:09
11 tasks
kiftio
force-pushed
the
use_onDismiss_rather_than_onCancel_in_react-native
branch
from
July 16, 2026 12:25
809c8b0 to
ba83ff8
Compare
kiftio
force-pushed
the
07-16-updates_accelerated_checkouts_to_use_ondismiss
branch
from
July 16, 2026 12:25
e828251 to
1658436
Compare
kiftio
force-pushed
the
07-16-updates_accelerated_checkouts_to_use_ondismiss
branch
from
July 16, 2026 12:51
1658436 to
80afddb
Compare
kiftio
force-pushed
the
use_onDismiss_rather_than_onCancel_in_react-native
branch
from
July 16, 2026 12:51
ba83ff8 to
e9351f0
Compare
kiftio
marked this pull request as ready for review
July 17, 2026 09:37
Package Size
React Native file breakdown
Measured from the PR base SHA and PR head SHA. The file breakdown shows uncompressed sizes within each package artifact, so individual files do not sum to the compressed artifact total. This comment reports package artifact sizes only; it is not a final app binary-size report. |
Checkout Kit E2E results
Warning Expected 2 runs, received 0 — 2 did not report. Missing runs count as failures until every run reports. |
kiftio
changed the base branch from
07-16-updates_accelerated_checkouts_to_use_ondismiss
to
graphite-base/483
July 17, 2026 13:02
kieran-osgood-shopify
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changes are you making?
Renames the checkout cancellation callback to better reflect its intent across both platforms:
onCheckoutCanceled()→onCheckoutDismissed()inCustomCheckoutListenercheckoutDidCancel()→checkoutDidDismiss()in theCheckoutDelegateextensionDefaultCheckoutListener.onCheckoutDismissedinstead ofDefaultCheckoutEventProcessor.onCheckoutCanceledThe rename aligns the naming convention with the underlying SDK's terminology, making it clearer that this event fires when the buyer dismisses the checkout sheet (e.g. tapping the close button) rather than implying the buyer explicitly cancelled their purchase.
How to test
onClosecallback fires as expected on both platforms.ShopifyCheckoutKitModuleTestand confirm all tests pass.ShopifyCheckoutKitTestsand confirmtestCheckoutDidDismissDismissesCheckoutSheetFromRCTWrapperpasses.Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/README.md(major version only)Releasing a new Embedded Checkout Protocol version?
embeddedCheckoutProtocolAndroidinplatforms/android/gradle/libs.versions.tomlprotocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.apiif the public API changedReleasing a new Android version?
checkoutKitAndroidinplatforms/android/gradle/libs.versions.tomlplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.