Skip to content

ci: add CI workflow#3

Closed
ShmuelMax100 wants to merge 5 commits intomainfrom
feature/shmuel/ci-workflow
Closed

ci: add CI workflow#3
ShmuelMax100 wants to merge 5 commits intomainfrom
feature/shmuel/ci-workflow

Conversation

@ShmuelMax100
Copy link
Copy Markdown
Owner

Adds ci.yml (lint, test matrix, build).

@ShmuelMax100
Copy link
Copy Markdown
Owner Author

Re-trigger workflows

Shmuel Max and others added 5 commits April 30, 2026 10:51
- actions/cache@1bd1...c6158d was a typo; real v4.2.0 SHA ends in c30a57
- src/test_app.py imports were unsorted (ruff I001)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
SHAs were noisy and a foot-gun for learners (one bad char broke CI).
Switch all examples and the exercise to @v4/@v5 tags.
The security-best-practices guide still discusses SHA-pinning as a
production hardening step; that's where it belongs.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@ShmuelMax100 ShmuelMax100 force-pushed the feature/shmuel/ci-workflow branch from 4682d38 to 01ddb50 Compare April 30, 2026 07:52
@ShmuelMax100
Copy link
Copy Markdown
Owner Author

Closing — this PR was a demo of the completed exercise. Merging would put ci.yml on main and break the exercise for future students. The reference solution lives at solutions/02-ci-workflow/.

@ShmuelMax100 ShmuelMax100 deleted the feature/shmuel/ci-workflow branch April 30, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant