Skip to content

Add common_javacopts to make_scala_rules call site #1867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-leuthaeuser merged 2 commits into from
Sep 23, 2026
Merged

Add common_javacopts to make_scala_rules call site #1867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f26f4d
Add common_javacopts to make_scala_rules call site
max-leuthaeuser Sep 23, 2026
6fae599
Point bazel_tooling back at joernio (PR merged)
max-leuthaeuser Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ bazel_dep(name = "rules_jvm_external", version = "7.0")
bazel_dep(name = "aspect_rules_lint", version = "2.5.2")
bazel_dep(name = "buildifier_prebuilt", version = "8.5.1.2")

BAZEL_TOOLING_VERSION = "4bcf42cc81b574b91699d696b504637677640871"
BAZEL_TOOLING_VERSION = "fbdfc66995360c408ecf94d34837a0355aa7ac4d"

git_override(
module_name = "bazel_tooling",
Expand Down
8 changes: 8 additions & 0 deletions bazel/scala.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,14 @@ _rules = make_scala_rules(
"-deprecation",
"-Wconf:msg=Implicit parameters should be provided with a `using` clause:s",
],
# Applies to the Java sources of mixed Java/Scala targets which rules_scala
# compiles in a separate Javac action that does not see the javacopts from
# bazel/java.bzl. Keep in sync with java_common_opts there.
common_javacopts = [
"--release",
"17",
"-XepDisableAllChecks",
],
common_scala_binary_runtime_deps = [],
common_scala_test_runtime_deps = [],
)
Expand Down
Loading