Skip to content

Remove interactive flow references from CLI architecture spec#151

Open
nick-pape wants to merge 1 commit intoSharePoint:mainfrom
nick-pape:nick-pape/remove-interactive-spec
Open

Remove interactive flow references from CLI architecture spec#151
nick-pape wants to merge 1 commit intoSharePoint:mainfrom
nick-pape:nick-pape/remove-interactive-spec

Conversation

@nick-pape
Copy link
Contributor

Description

Removes interactive prompt flow references from the CLI architecture spec. All CLI flows are non-interactive — every parameter must be supplied via flags.

Closes #95.

Changes

  • Removed "interactive prompts" from the CLI description
  • Removed the sentence describing a planned interactive fallback for missing parameters
  • Removed "Interactive fallback flow" from the Phase 2 plan

How was this tested

Docs-only change.

Type of change

  • Docs/CI

🤖 Generated with Claude Code

All CLI flows are non-interactive — every parameter must be supplied
via flags. Remove the three places in the spec that described interactive
fallback prompts as planned behavior.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings March 19, 2026 20:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the SPFx CLI architecture RFC to remove references to interactive prompting, aligning the document with the current design/behavior that CLI usage is flag-driven.

Changes:

  • Removed mentions of “interactive prompts” from the CLI description.
  • Removed the planned “interactive fallback” description for missing parameters.
  • Removed “Interactive fallback flow” from the Phase 2 plan.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +59 to +60
to `@microsoft/spfx-template-api`. All flows are non-interactive — every parameter
must be supplied via flags.
Copy link

Copilot AI Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The statement “every parameter must be supplied via flags” conflicts with the parameter table below, which explicitly marks several parameters as optional with defaults (e.g., --target-dir defaults to CWD, --component-alias defaults to component name). Consider rephrasing to “no interactive prompting; any required parameters must be supplied via flags (missing required params error)” so the doc is internally consistent.

Suggested change
to `@microsoft/spfx-template-api`. All flows are non-interactive — every parameter
must be supplied via flags.
to `@microsoft/spfx-template-api`. All flows are non-interactive — there is no prompting;
any required parameters must be supplied via flags, and optional parameters use documented
defaults when omitted.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement interactive fallback flows for missing CLI parameters

2 participants