Conversation
* Rewrite the basic legacy isCurrentEvent usages in favor of ERS * Do the TODOs ERS * clean up imports/formatting * Implement ERS in EffHidePlayerFromServerList * Fix the else block formatting Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com> * Remove the check for paper event exisiting in EffHidePlayerFromServerList Co-authored-by: SirSmurfy2 <82696841+Absolutionism@users.noreply.github.com> * Remove the unused PAPER_EVENT_EXISTS from EffHidePlayerFromServerList * Remove redundant PAPER_EVENT_EXISTS checks and expand ERS usage * revert EffLoadServerIcon invalid ERS implementation * clean up event class conversions Co-authored-by: SirSmurfy2 <82696841+Absolutionism@users.noreply.github.com> * clean up event class conversions in ExprIP * Add missing blank lines * clean up imports in EffLoadServerIcon * clean up imports in ExprHoverList --------- Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com> Co-authored-by: SirSmurfy2 <82696841+Absolutionism@users.noreply.github.com>
* fix(string-color): add isEmpty before tag check * chore(tests): add regression test for #8550 * fix(string-color): move isEmpty check to separate guard
… loading threads (#8563)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates from upstream