[SPH] use std::shared_ptr for edges internally in ComputeEOS

[tdavidcl]

No description provided.

[github-actions]

Thanks @tdavidcl for opening this PR!

You can do multiple things directly here:
1 - Comment pre-commit.ci run to run pre-commit checks.
2 - Comment pre-commit.ci autofix to apply fixes.
3 - Add label autofix.ci to fix authorship & pre-commit for every commit made.
4 - Add label full-ci to run the full test suite (default is light CI; full CI also runs on Mergify merge-queue branches).
5 - Add label trigger-ci to create an empty commit to trigger the CI.

Once the workflow completes a message will appear displaying informations related to the run.

Also the PR gets automatically reviewed by gemini, you can:
1 - Comment /gemini review to trigger a review
2 - Comment /gemini summary for a summary
3 - Tag it using @gemini-code-assist either in the PR or in review comments on files

[coderabbitai]

Warning

Review limit reached

@tdavidcl, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Limit details: You’ve used all 1 included review currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: fd3687e1-0238-49f2-8844-17b97e94ad96

📥 Commits

Reviewing files that changed from the base of the PR and between 92cccdf and 225b1e2.

📒 Files selected for processing (2)

• src/shammodels/sph/include/shammodels/sph/modules/ComputeEos.hpp
• src/shammodels/sph/src/modules/ComputeEos.cpp

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Workflow report

workflow report corresponding to commit 225b1e2
Commiter email is timothee.davidcleris@proton.me

Light CI is enabled (the default for pull requests). This will only run the basic tests and not the full tests.
Full CI runs if the full-ci label is set, or automatically on Mergify merge-queue branches (mergify/merge-queue/*).
The merge gate job "on PR / all" is skipped in this case. Queue entry uses "on PR / all_light"; full CI runs in the merge queue.

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks................................................Passed
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
cmake-format.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
ruff check...............................................................Passed
ruff format..............................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed
No ssh in git submodules remote..........................................Passed
No UTF-8 in files (except for authors)...................................Passed

Test pipeline can run.

Clang-tidy diff report

631 warnings generated.
Suppressed 632 warnings (631 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

1217 warnings generated.
Suppressed 1218 warnings (1217 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

Doxygen diff with main

Removed warnings : 9
New warnings : 9
Warnings count : 8183 → 8183 (0.0%)

Detailed changes :

- src/shammodels/sph/include/shammodels/sph/modules/ComputeEos.hpp:37: warning: Member Tscal (typedef) of class shammodels::sph::modules::ComputeEos is not documented.
- src/shammodels/sph/include/shammodels/sph/modules/ComputeEos.hpp:38: warning: Member dim (variable) of class shammodels::sph::modules::ComputeEos is not documented.
- src/shammodels/sph/include/shammodels/sph/modules/ComputeEos.hpp:39: warning: Member Kernel (typedef) of class shammodels::sph::modules::ComputeEos is not documented.
- src/shammodels/sph/include/shammodels/sph/modules/ComputeEos.hpp:41: warning: Member Config (typedef) of class shammodels::sph::modules::ComputeEos is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/ComputeEos.hpp:41: warning: Member Tscal (typedef) of class shammodels::sph::modules::ComputeEos is not documented.
- src/shammodels/sph/include/shammodels/sph/modules/ComputeEos.hpp:42: warning: Member Storage (typedef) of class shammodels::sph::modules::ComputeEos is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/ComputeEos.hpp:42: warning: Member dim (variable) of class shammodels::sph::modules::ComputeEos is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/ComputeEos.hpp:43: warning: Member Kernel (typedef) of class shammodels::sph::modules::ComputeEos is not documented.
- src/shammodels/sph/include/shammodels/sph/modules/ComputeEos.hpp:44: warning: Member context (variable) of class shammodels::sph::modules::ComputeEos is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/ComputeEos.hpp:45: warning: Member Config (typedef) of class shammodels::sph::modules::ComputeEos is not documented.
- src/shammodels/sph/include/shammodels/sph/modules/ComputeEos.hpp:45: warning: Member solver_config (variable) of class shammodels::sph::modules::ComputeEos is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/ComputeEos.hpp:46: warning: Member Storage (typedef) of class shammodels::sph::modules::ComputeEos is not documented.
- src/shammodels/sph/include/shammodels/sph/modules/ComputeEos.hpp:46: warning: Member storage (variable) of class shammodels::sph::modules::ComputeEos is not documented.
- src/shammodels/sph/include/shammodels/sph/modules/ComputeEos.hpp:48: warning: Member ComputeEos(ShamrockCtx &context, Config &solver_config, Storage &storage) (function) of class shammodels::sph::modules::ComputeEos is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/ComputeEos.hpp:48: warning: Member context (variable) of class shammodels::sph::modules::ComputeEos is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/ComputeEos.hpp:49: warning: Member solver_config (variable) of class shammodels::sph::modules::ComputeEos is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/ComputeEos.hpp:50: warning: Member storage (variable) of class shammodels::sph::modules::ComputeEos is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/ComputeEos.hpp:52: warning: Member ComputeEos(ShamrockCtx &context, Config &solver_config, Storage &storage) (function) of class shammodels::sph::modules::ComputeEos is not documented.

[mergify]

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

• Queue this pull request