Skip to content

Pr/tara/grok integration#123

Open
tara-servicenow wants to merge 9 commits into
mainfrom
pr/tara/grok_integration
Open

Pr/tara/grok integration#123
tara-servicenow wants to merge 9 commits into
mainfrom
pr/tara/grok_integration

Conversation

@tara-servicenow
Copy link
Copy Markdown
Collaborator

No description provided.

tara-servicenow and others added 9 commits May 20, 2026 15:49
… as class attrs

Adds _service_name and _metrics_processor_name class-level attributes to
OpenAIRealtimeAssistantServer so subclasses (e.g. GrokVoiceAssistantServer)
can override them without duplicating log/metrics wiring. Default values
preserve all existing log strings on the OpenAI path.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ice_name

Caught in code review of a78d0204.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Pulls the session_config dict literal out of _handle_session into its
own overridable method, using _default_voice() for the voice fallback.
Behavior on the OpenAI path is byte-for-byte preserved.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…class

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…er Grok api_key guard

Final-review findings from the implementation plan: one log line was
still hardcoded "Unhandled OpenAI event" and the Grok subclass's
_create_client missing-key path lacked a test.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants