Add dynamic guidance tasks #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marquezo
reviewed
Dec 10, 2025
Comment on lines
+14
to
+35
| class ServiceNowIncidentTask(AbstractServiceNowTask): | ||
|
|
||
| def __init__(self, seed: int, fixed_config: Dict[str, Any] = None, start_rel_url: str = "/now/nav/ui/home") -> None: | ||
| super().__init__(seed, start_rel_url=start_rel_url) | ||
| self.task_is_setup = False | ||
| self.config = fixed_config if fixed_config else self.random.choice(self.all_configs()) | ||
| self.timeout = 60000 | ||
| self.created_sysids = [] | ||
|
|
||
| def setup_goal(self, page: playwright.sync_api.Page) -> Tuple[str, dict]: | ||
| """Setup the task configuration and produce the goal.""" | ||
|
|
||
| goal = self.config["goal"] | ||
| info = self.config | ||
|
|
||
| return goal, info | ||
|
|
||
| def cheat(self, page: playwright.sync_api.Page, chat_messages: List[str]) -> None: | ||
| pass | ||
|
|
||
| def all_configs(self): | ||
| raise NotImplementedError |
Collaborator
There was a problem hiding this comment.
for these create incidents we should just reuse what exists. I will do a PR for these incident tasks
marquezo
reviewed
Dec 10, 2025
Comment on lines
+48
to
+56
| response = requests.get( | ||
| f"{self.instance.snow_url}/api/now/table/interaction", | ||
| auth=self.instance.snow_credentials, | ||
| headers={"Accept": "application/json"}, | ||
| params={ | ||
| "sysparm_query": f"short_descriptionLIKE{customer_problem}", | ||
| "sysparm_fields": "sys_id,short_description", | ||
| "sysparm_limit": 1, | ||
| }, |
Collaborator
There was a problem hiding this comment.
why don't you just validate by getting the sys id of the created interaction and then checking whether the short description matches the expected value? This way, we can just reuse the other create tasks code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.