Skip to content

Universal XMP Tags #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Universal XMP Tags #89

wants to merge 4 commits into from

Conversation

@joeyfranck56
Copy link
Contributor

@joeyfranck56 joeyfranck56 commented Nov 5, 2025

Universal XMP Tags

What?

  • Set default XMP tags for tags that are universal across camera makers

Why?

  • Some XMP tags are consistent across camera makers and should be used as the default for sensors that are not made by Sentera, DJI, Micasense, or Parrot.
  • Setting these as the default will allow new sensors to be supported easier.
  • Sensors without these tags would already throw a keyerror so setting a default would do the same if images do not have these tags.

PR Checklist

  • Merged latest master
  • Updated version number

Breaking Changes

elliott-imhoff
elliott-imhoff reviewed Nov 12, 2025
View reviewed changes
mypy.ini
explicit_package_bases = True
scripts_are_modules = True
strict = True
warn_unused_ignores = False
Copy link
Member

@elliott-imhoff elliott-imhoff Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete the unused ignore comment instead of setting this

elliott-imhoff
elliott-imhoff reviewed Nov 12, 2025
View reviewed changes
Copy link
Member

@elliott-imhoff elliott-imhoff left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the doc string on the XMPTags class to say either empty strings or common defaults. If the tag doesn't exist, a KeyError will be thrown. Other than that, this looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elliott-imhoff elliott-imhoff elliott-imhoff left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joeyfranck56 @elliott-imhoff