Repository navigation
fix(klaud): unblock AgentX smoke and stop re-picking blocked candidates / fix(klaud): 修复 AgentX 冒烟测试并停止重复选择受阻候选 #4075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -143,7 +143,7 @@ def smoke_entries(entries: list[dict]) -> list[dict]: | |
| row.pop(Fields.REQUIRE_POWER.value, None) | ||
| if row.get("prefill") is not None: | ||
| row["conc"] = [row["eval-conc"]] | ||
| row["eval-all-concs"] = False | ||
| row.pop("eval-all-concs", None) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📊 Line Count Report
|
||
| evals.append(row) | ||
| return benchmarks + trim_conc(evals) | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 A transient failure downloading or parsing a candidate's outcome artifact now silently blocks that candidate from the next ~cooldown_hours of waves. recorded_outcome() (L202-217) returns None on any OSError/ValueError/KeyError/TypeError/SubprocessError from download_json or from reading candidate-diagnostics.json, and order_by_cooldown() (L220-225) treats id->None the same as a real 'blocked' outcome: it's excluded from both
freshanddeferred, so the candidate disappears from review until the artifact ages out of the cooldown window. Fix: distinguish 'outcome unknown/fetch failed' from a real blocking outcome so transient failures don't exclude a candidate for the full cooldown window; e.g. keep such ids out ofrecentinstead of mapping them to None.Why this was flagged
Trigger: a gh api zip download for one candidate's artifact times out, hits a rate limit, or the zip/json is malformed (any OSError/ValueError/SubprocessError), which recorded_outcome() at main.py:210-217 catches and turns into outcome=None instead of propagating or dropping the id. order_by_cooldown() (L220-225) requires recent.get(id) in RETRY_NEXT_WAVE to retry; None fails that test just like a genuine 'readiness-blocked' outcome, so the candidate is dropped from both fresh and deferred lists for the whole cooldown_hours window (24h in the workflow). On base branch, the only failure path was the outer github_items call in recent_candidate_ids, which failed open (returned empty set, candidates unaffected); this diff adds a per-artifact network/parse path with no equivalent fail-open behavior, so legitimate candidates can be starved of review for up to 24h by an unrelated GitHub API hiccup, with waves now running every 2h (klaud-plan.yml cron) increasing total download volume and therefore the odds of hitting this.
Verification: nit. recorded_outcome() (main.py:202-217) catches OSError/ValueError/KeyError/TypeError/subprocess.SubprocessError and returns None; download_json() (github.py:54-82) raises these on gh api timeout, non-zero exit, or malformed zip. The id is still stored in
recent(L198) with value None. order_by_cooldown (L220-225) then excludes it from bothfreshanddeferred, dropping it like a genuine blocked outcome.