Skip to content

[AgentX]: B300 Kimi K3 DSpark refresh #2476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cquil11 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[AgentX]: B300 Kimi K3 DSpark refresh #2476

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
743b761
perf(agentx): refresh B300 Kimi K3 DSpark
cquil11 Aug 3, 2026
1103b86
chore: link B300 DSpark refresh PR
cquil11 Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions perf-changelog.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5374,3 +5374,8 @@
- "Image: lmsysorg/sglang:v0.5.16-cu130"
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/2420

- config-keys:
- kimik3-fp4-b300-vllm-agentic-dspark
description:
- "Refresh B300 Kimi K3 DSpark submission with corrected AgentX harness"
Comment on lines +5377 to +5380

@claude claude Bot Aug 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 AGENTS.md (Git conventions, line 82) requires every commit message/PR title to include a Simplified Chinese translation alongside English, since squash-merge inherits the PR title as the commit subject. Both this PR's title ('[AgentX]: B300 Kimi K3 DSpark refresh') and the resulting squash commit are English-only with no 中文 translation. This is a metadata/convention gap, not a functional bug, so it's easily fixed by amending the PR title (or a follow-up commit note) to add the Chinese translation.

Extended reasoning...

What the convention requires: AGENTS.md states under Git conventions: "Commit messages must include a Simplified Chinese translation in addition to English — keep the subject line in English (conventional-commit style), then include the Chinese translation of the subject and key body points in the commit body... Squash-merge commits inherit the bilingual PR title, which satisfies the subject requirement automatically." That last sentence makes the PR title the actual enforcement point for squash-merged PRs like this one, since GitHub squash-merge by default uses the PR title as the resulting commit subject.

Where it was violated: The PR title is [AgentX]: B300 Kimi K3 DSpark refresh — English only, no 中文： translation. I confirmed the resulting merged commit with git log -1 --format=%B 743b761, which returns exactly perf(agentx): refresh B300 Kimi K3 DSpark with no body and no Chinese translation at all. Per the AGENTS.md rule, this commit needed either a bilingual PR title (inherited into the subject) or a trailing 中文：<translation> paragraph in the body — it has neither.

Why nothing else in the repo catches this: There is no CI check enforcing bilingual commit/PR titles (unlike the doc-mirroring rule for _zh.md files, which is a hard requirement with its own convention but still no automated gate that I could find). Enforcement here is purely reviewer-driven, which is why it slipped through on this PR as well as on the immediately preceding commits (#2420, #2421, #2464) — this appears to be a widely-unenforced convention rather than something unique to this change.

Step-by-step proof:

  1. AGENTS.md line 82 (Git conventions section) states the bilingual requirement and explicitly calls out that squash-merge commits satisfy it via the PR title.
  2. This PR's title, as shown in the PR metadata, is [AgentX]: B300 Kimi K3 DSpark refresh — no Chinese text present.
  3. git log -1 --format=%B 743b761 (the squash-merge commit that added this perf-changelog.yaml entry) returns a single English line, perf(agentx): refresh B300 Kimi K3 DSpark, with no body and no 中文： section.
  4. Therefore the bilingual-subject requirement in AGENTS.md was not satisfied by either the PR title or the merged commit body.

Impact and fix: This causes no functional failure — the changelog entry, config keys, and PR content are all correct, and nothing breaks at merge or runtime. It is a documentation/process compliance gap. The fix is simply to amend the PR title (or add a commit-body note before merge) to include a 中文：<subject translation> line, e.g. 中文：刷新 B300 Kimi K3 DSpark 提交. Given the non-functional nature and the fact that recent adjacent commits have the same gap, this should be treated as a nit rather than a blocking issue.

pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/2476