-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add Python examples for W3C BiDi network intercept commands #2639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ajithrao2509
wants to merge
4
commits into
SeleniumHQ:trunk
Choose a base branch
from
ajithrao2509:add-python-bidi-network-examples
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+117
−5
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
6df5977
Add Python BiDi network intercept examples
ajithrao2509 7e1adcc
Add Python tab references to W3C BiDi network docs
ajithrao2509 55e2b79
fix test_fail_request to actually invoke fail_request and add assertion
ajithrao2509 dcfd84b
Address Qodo review: add comments for private APIs, verify handler re…
ajithrao2509 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| # Licensed to the Software Freedom Conservancy (SFC) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The SFC licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| import pytest | ||
|
|
||
|
|
||
| @pytest.mark.driver_type("bidi") | ||
| def test_add_intercept(driver): | ||
| # _add_intercept is currently the available Python API for BiDi network intercepts. | ||
| # This will be updated when a public API is stabilized. | ||
| intercept = driver.network._add_intercept() | ||
| assert intercept is not None | ||
|
|
||
|
|
||
| @pytest.mark.driver_type("bidi") | ||
| def test_remove_intercept(driver): | ||
| # _add_intercept/_remove_intercept are currently the available Python APIs. | ||
| # These will be updated when a public API is stabilized. | ||
| intercept = driver.network._add_intercept() | ||
| driver.network._remove_intercept(intercept["intercept"]) | ||
| assert driver.network.intercepts == [] | ||
|
|
||
|
|
||
| @pytest.mark.driver_type("bidi") | ||
| def test_fail_request(driver): | ||
| from selenium.webdriver.common.bidi.network import Request | ||
|
|
||
| failed_requests = [] | ||
|
|
||
| intercept = driver.network._add_intercept() | ||
|
|
||
| def on_request(request: Request): | ||
| failed_requests.append(request) | ||
| driver.network.fail_request(request.request["requestId"]) | ||
|
|
||
| driver.network.add_request_handler("before_request", on_request) | ||
|
|
||
| try: | ||
| driver.get("https://www.selenium.dev/selenium/web/blank.html") | ||
| except Exception: | ||
| pass | ||
|
|
||
| import time | ||
| time.sleep(1) | ||
|
|
||
| assert len(failed_requests) > 0 | ||
| driver.network._remove_intercept(intercept["intercept"]) | ||
| driver.network.clear_request_handlers() | ||
|
|
||
|
|
||
| @pytest.mark.driver_type("bidi") | ||
| def test_add_and_remove_request_handler(driver): | ||
| from selenium.webdriver.common.bidi.network import Request | ||
|
|
||
| requests = [] | ||
|
|
||
| def callback(request: Request): | ||
| requests.append(request) | ||
|
|
||
| callback_id = driver.network.add_request_handler("before_request", callback) | ||
| assert callback_id is not None | ||
|
|
||
| driver.network.remove_request_handler("before_request", callback_id) | ||
| assert callback_id not in [ | ||
| h for h in driver.network._handlers.get("before_request", []) | ||
| ] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.