[py] Add edge service arg to inherit browser i/o streams#17415
Open
cgoldberg wants to merge 1 commit intoSeleniumHQ:trunkfrom
Open
[py] Add edge service arg to inherit browser i/o streams#17415cgoldberg wants to merge 1 commit intoSeleniumHQ:trunkfrom
cgoldberg wants to merge 1 commit intoSeleniumHQ:trunkfrom
Conversation
Contributor
Review Summary by QodoAdd --enable-chrome-logs to Edge service for browser i/o stream control
WalkthroughsDescription• Add --enable-chrome-logs flag to Edge service startup • Enables browser i/o stream inheritance for proper logging control • Aligns Edge driver behavior with existing Chrome driver implementation File Changes1. py/selenium/webdriver/edge/service.py
|
Member
Author
|
The RBE failure was Ruby related.. all Python tests in CI passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issues
Fixes #17414
This PR is the same as #16202 for chromedriver
💥 What does this PR do?
This PR adds the
--enable-chrome-logsargument when startingmsedgedriver. This allows it to inherit the i/o streams from the browser process. Without this, we have no way to suppress or redirect browser i/o streams, which results in unwanted logging going to the user's console.🔧 Implementation Notes
msedgedriveruses the same command line args aschromedriverThis same fix has been in the chrome
Serviceclass for several releases, so it should be safe.🤖 AI assistance
💡 Additional Considerations
🔄 Types of changes