Skip to content

[py] Add edge service arg to inherit browser i/o streams#17415

Open
cgoldberg wants to merge 1 commit intoSeleniumHQ:trunkfrom
cgoldberg:py-edge-enable-logs
Open

[py] Add edge service arg to inherit browser i/o streams#17415
cgoldberg wants to merge 1 commit intoSeleniumHQ:trunkfrom
cgoldberg:py-edge-enable-logs

Conversation

@cgoldberg
Copy link
Copy Markdown
Member

🔗 Related Issues

Fixes #17414
This PR is the same as #16202 for chromedriver

💥 What does this PR do?

This PR adds the --enable-chrome-logs argument when starting msedgedriver. This allows it to inherit the i/o streams from the browser process. Without this, we have no way to suppress or redirect browser i/o streams, which results in unwanted logging going to the user's console.

🔧 Implementation Notes

msedgedriver uses the same command line args as chromedriver

This same fix has been in the chrome Service class for several releases, so it should be safe.

🤖 AI assistance

  • No substantial AI assistance used
  • AI assisted (complete below)
    • Tool(s):
    • What was generated:
    • I reviewed all AI output and can explain the change

💡 Additional Considerations

🔄 Types of changes

  • Bug fix (backwards compatible)

@qodo-code-review
Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Add --enable-chrome-logs to Edge service for browser i/o stream control

🐞 Bug fix

Grey Divider

Walkthroughs

Description
• Add --enable-chrome-logs flag to Edge service startup
• Enables browser i/o stream inheritance for proper logging control
• Aligns Edge driver behavior with existing Chrome driver implementation

Grey Divider

File Changes

1. py/selenium/webdriver/edge/service.py 🐞 Bug fix +4/-0

Add command_line_args method with enable-chrome-logs flag

• Added command_line_args() method to Edge service class
• Returns command line arguments including --enable-chrome-logs flag
• Ensures msedgedriver inherits browser i/o streams like chromedriver
• Allows suppression and redirection of browser logging output

py/selenium/webdriver/edge/service.py


Grey Divider

Qodo Logo

@selenium-ci selenium-ci added the C-py Python Bindings label May 5, 2026
@SeleniumHQ SeleniumHQ deleted a comment from qodo-code-review Bot May 5, 2026
@cgoldberg cgoldberg changed the title [py] Add --enable-chrome-logs to edge service args to inherit browser i/o streams [py] Add edge service arg to inherit browser i/o streams May 5, 2026
@cgoldberg
Copy link
Copy Markdown
Member Author

The RBE failure was Ruby related.. all Python tests in CI passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-py Python Bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: [py] Selenium Edge driver outputting unwanted log in console "DevTools listening on..." persistent problem

2 participants