[py] Add unit tests for selenium.webdriver.common.timeouts#17389
Open
EternalRights wants to merge 3 commits intoSeleniumHQ:trunkfrom
Open
[py] Add unit tests for selenium.webdriver.common.timeouts#17389EternalRights wants to merge 3 commits intoSeleniumHQ:trunkfrom
EternalRights wants to merge 3 commits intoSeleniumHQ:trunkfrom
Conversation
Contributor
Review Summary by QodoAdd unit tests for selenium.webdriver.common.timeouts
WalkthroughsDescription• Add comprehensive unit tests for Timeouts class initialization • Test _convert method for seconds-to-milliseconds conversion • Test _TimeoutsDescriptor descriptor pattern for get/set behavior • Test _to_json serialization with zero-value omission File Changes1. py/test/unit/selenium/webdriver/common/timeouts_tests.py
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into this while looking at test coverage gaps in the Python bindings. The timeouts module had zero tests despite having some non-trivial logic (descriptor pattern for ms<->sec conversion, type validation, JSON serialization with zero-value omission).
Covered:
Style follows existing tests in this directory (by_tests, proxy_tests).