[JavaScript] Move 'isDisplayed' atom to be typescript by AutomatedTester · Pull Request #17316 · SeleniumHQ/selenium

AutomatedTester · 2026-04-08T14:32:29Z

🔗 Related Issues

💥 What does this PR do?

Addiditive PR that moves Python code to use the newly created isDisplayed TypeScript implementation

🔧 Implementation Notes

💡 Additional Considerations

🔄 Types of changes

New feature (non-breaking change which adds functionality and tests!)

Copilot

Pull request overview

This PR introduces a new TypeScript-based implementation of the isDisplayed/isShown atom, wires it into Bazel targets, and switches the Python binding’s packaged isDisplayed.js to use the new implementation.

Changes:

Added a new TypeScript isShown implementation plus corresponding JS artifacts (is-displayed.js, is-displayed-global.js).
Added a new is-displayed-typescript fragment target and a selenium-webdriver is_displayed_typescript module build target.
Updated the Python Bazel packaging step to copy the TypeScript-based fragment as selenium/webdriver/remote/isDisplayed.js, and added new QUnit HTML tests for the TS variant.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
`py/BUILD.bazel`	Switches Python’s packaged `isDisplayed.js` atom source to the new TS-based fragment output.
`javascript/selenium-webdriver/lib/atoms/BUILD.bazel`	Adds a build rule to wrap the TS-based fragment for Node/module consumption.
`javascript/atoms/typescript/is-displayed.ts`	Adds the new TypeScript source implementation of `isShown`.
`javascript/atoms/typescript/is-displayed.js`	Adds the JS artifact used as the fragment source for Bazel/copying.
`javascript/atoms/typescript/is-displayed-global.js`	Adds a global `window.bot.dom.typescript.isShown` build used by HTML tests.
`javascript/atoms/test/shown_typescript_test.html`	Adds a TS-focused clone of the existing `shown_test.html`.
`javascript/atoms/test/html5/shadow_dom_typescript_test.html`	Adds a TS-focused clone of the existing shadow-dom shown tests.
`javascript/atoms/fragments/BUILD.bazel`	Adds a new fragment target that copies in the TS-based implementation.
`javascript/atoms/BUILD.bazel`	Expands the atoms filegroup glob to include `*/.ts`.

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 75 out of 81 changed files in this pull request and generated 5 comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

…ia Bazel - Fix invalid Bazel label in js_binary: entry_point must not use the ':' target prefix when the path contains '/'. Changed ':typescript/strip-trailing-semicolon.js' to the file-path form 'typescript/strip-trailing-semicolon.js'. - Add wrap-as-global.js Node script that wraps the compiled TypeScript atom output with the window.bot.dom.typescript.isShown global assignment (plus license header), mirroring the pattern of strip-trailing-semicolon.js. - Add 'wrap_as_global' js_binary and 'is-displayed-global' js_run_binary rules so is-displayed-global.js is generated from the same TypeScript source rather than being a separate hand-maintained copy that could drift. - Remove the hand-maintained javascript/atoms/typescript/is-displayed-global.js; it is now produced by the new Bazel rule. Fixes review comments in PR #17316.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

…ia Bazel - Fix invalid Bazel label in js_binary: entry_point must not use the ':' target prefix when the path contains '/'. Changed ':typescript/strip-trailing-semicolon.js' to the file-path form 'typescript/strip-trailing-semicolon.js'. - Add wrap-as-global.js Node script that wraps the compiled TypeScript atom output with the window.bot.dom.typescript.isShown global assignment (plus license header), mirroring the pattern of strip-trailing-semicolon.js. - Add 'wrap_as_global' js_binary and 'is-displayed-global' js_run_binary rules so is-displayed-global.js is generated from the same TypeScript source rather than being a separate hand-maintained copy that could drift. - Remove the hand-maintained javascript/atoms/typescript/is-displayed-global.js; it is now produced by the new Bazel rule. Fixes review comments in PR #17316.

Replace all 'instanceof Element' (and related HTMLFormElement, HTMLMapElement, HTMLAreaElement) checks with nodeType-based checks so that isShown correctly handles Elements originating from a different JS realm (e.g., elements from an iframe). Closes review comment r3118809041 on PR #17316. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Port the getAttribute WebDriver atom from Google Closure (javascript/webdriver/atoms/attribute.js) to TypeScript following the pattern established for is-displayed in PR #17316. Changes: - javascript/atoms/typescript/get-attribute.ts: TypeScript IIFE implementation of the getAttribute atom. Drops IE compatibility (IE_DOC_PRE8/PRE9, getAttributeNode quirks), uses nodeType-based isElement() for cross-realm safety. Preserves all existing behavior: style → cssText, selected/checked state-based, href/src property resolution, spellcheck normalisation, boolean property list, PROPERTY_ALIASES (class→className, readonly→readOnly). - javascript/atoms/typescript/strip-trailing-semicolon.js: Node script that removes the trailing semicolon tsc adds after the IIFE, so the output can be injected as a JS expression. - javascript/atoms/typescript/wrap-get-attribute-as-global.js: Node script that wraps the compiled output as window.bot.dom.typescript.getAttribute for use in browser tests. - javascript/atoms/test/attribute_typescript_test.html: QUnit test page for the TypeScript atom covering named attrs, class, missing attrs, empty string, boolean attrs, selected/checked state, href/src URL resolution, style cssText, spellcheck, case insensitivity, expandos. - javascript/atoms/BUILD.bazel: Adds js_binary and js_run_binary rules to compile TypeScript → strip semicolon → wrap as global; updates the atoms filegroup to include .ts sources and the generated global. - javascript/atoms/fragments/BUILD.bazel: Adds copy_file rule get-attribute-typescript exposing the generated JS as a fragment. - py/BUILD.bazel: Switches the get-attribute copy_file to use //javascript/atoms/fragments:get-attribute-typescript.js instead of the Closure-compiled fragment. The old Closure get-attribute fragment is kept unchanged so that Ruby, Java, .NET, and JavaScript bindings are not affected. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…ia Bazel - Fix invalid Bazel label in js_binary: entry_point must not use the ':' target prefix when the path contains '/'. Changed ':typescript/strip-trailing-semicolon.js' to the file-path form 'typescript/strip-trailing-semicolon.js'. - Add wrap-as-global.js Node script that wraps the compiled TypeScript atom output with the window.bot.dom.typescript.isShown global assignment (plus license header), mirroring the pattern of strip-trailing-semicolon.js. - Add 'wrap_as_global' js_binary and 'is-displayed-global' js_run_binary rules so is-displayed-global.js is generated from the same TypeScript source rather than being a separate hand-maintained copy that could drift. - Remove the hand-maintained javascript/atoms/typescript/is-displayed-global.js; it is now produced by the new Bazel rule. Fixes review comments in PR #17316.

- Replace Element.closest('select') with a manual ancestor walk for OPTION/OPTGROUP visibility, avoiding crashes in environments without closest() support (e.g. IE11) - Replace 'instanceof HTMLDetailsElement' with an isElement('DETAILS') tagName check to avoid ReferenceError in browsers that do not define HTMLDetailsElement - Fix js_run_binary srcs to use explicit file label '//javascript/atoms/fragments:is-displayed-typescript.js' instead of the rule label to match the established pattern Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Replace all 'instanceof Element' (and related HTMLFormElement, HTMLMapElement, HTMLAreaElement) checks with nodeType-based checks so that isShown correctly handles Elements originating from a different JS realm (e.g., elements from an iframe). Closes review comment r3118809041 on PR #17316. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

- Cast elem to HTMLAreaElement when calling getAreaRelativeRect, since isElement() type guard only narrows to Element, not subtypes - Cast elem to Element before accessing parentNode to avoid TypeScript narrowing elem to never after the isElement(elem, 'BODY') false branch Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

A <form> with a child <input name="tagName"> shadows the form's native tagName DOM property. Accessing form.tagName returns the input element (not the string "FORM"), causing isElement() to return false for the form and throw 'Argument to isShown must be of type Element'. Fix by reading tagName via the Element.prototype getter, which bypasses form child property shadowing while remaining safe for cross-realm elements (the native getter operates on the underlying DOM node). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…heck The TypeScript isElement() uses nodeType !== 1 (not instanceof Element), so a cross-realm <title> element passes the check and isShown() returns false rather than throwing. Update test accordingly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

+    // Access tagName via the Element prototype getter to avoid property shadowing
+    // by form children: e.g. <form><input name="tagName"> shadows form.tagName.
+    var tagNameDescriptor = Object.getOwnPropertyDescriptor(Element.prototype, 'tagName');
+    var rawTagName = tagNameDescriptor && typeof tagNameDescriptor.get === 'function'
+      ? tagNameDescriptor.get.call(asElement)
+      : asElement.tagName;


+  <script type="text/javascript">
+    goog.require('bot.dom');
+  </script>


Copilot AI review requested due to automatic review settings April 8, 2026 14:32

selenium-ci added C-py Python Bindings B-atoms JavaScript chunks generated by Google closure C-nodejs JavaScript Bindings B-build Includes scripting, bazel and CI integrations labels Apr 8, 2026

Copilot started reviewing on behalf of AutomatedTester April 8, 2026 14:33 View session

Copilot AI reviewed Apr 8, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings April 8, 2026 15:50

Copilot started reviewing on behalf of AutomatedTester April 8, 2026 15:51 View session

Copilot AI reviewed Apr 8, 2026

View reviewed changes

Comment thread javascript/atoms/typescript/is-displayed.ts

Comment thread javascript/atoms/typescript/is-displayed.ts Outdated

Comment thread javascript/atoms/typescript/is-displayed-global.js Outdated

Comment thread javascript/atoms/typescript/is-displayed-global.js Outdated

Copilot AI review requested due to automatic review settings April 9, 2026 15:50

Copilot started reviewing on behalf of AutomatedTester April 9, 2026 15:50 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

Comment thread javascript/atoms/BUILD.bazel Outdated

Comment thread javascript/atoms/typescript/is-displayed.ts

Comment thread .github/workflows/bazel.yml

Comment thread rust/CHANGELOG.md

Comment thread .github/workflows/release.yml

AutomatedTester force-pushed the atoms-ts-isdisplayed branch 2 times, most recently from a6a2ff6 to ad8d8ed Compare April 9, 2026 19:23

Copilot AI review requested due to automatic review settings April 9, 2026 19:23

Copilot started reviewing on behalf of AutomatedTester April 9, 2026 19:24 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

Comment thread javascript/selenium-webdriver/lib/atoms/BUILD.bazel Outdated

Comment thread javascript/atoms/BUILD.bazel Outdated

Comment thread javascript/atoms/typescript/is-displayed.ts

Comment thread javascript/atoms/typescript/is-displayed-global.js Outdated

AutomatedTester force-pushed the atoms-ts-isdisplayed branch from ad8d8ed to c45daee Compare April 10, 2026 10:14

Copilot AI review requested due to automatic review settings April 18, 2026 11:02

Copilot started reviewing on behalf of AutomatedTester April 18, 2026 11:02 View session

Copilot AI reviewed Apr 18, 2026

View reviewed changes

Comment thread javascript/atoms/BUILD.bazel Outdated

Comment thread javascript/atoms/typescript/is-displayed-global.js Outdated

Copilot AI review requested due to automatic review settings April 21, 2026 16:00

Copilot started reviewing on behalf of harsha509 April 21, 2026 16:01 View session

Copilot AI reviewed Apr 21, 2026

View reviewed changes

Comment thread javascript/atoms/typescript/is-displayed.ts

AutomatedTester mentioned this pull request Apr 22, 2026

[js][py] Convert getAttribute atom from Closure to TypeScript #17370

Open

3 tasks

Copilot AI review requested due to automatic review settings April 25, 2026 11:54

AutomatedTester force-pushed the atoms-ts-isdisplayed branch from b9d3184 to c21f959 Compare April 25, 2026 11:54

Copilot started reviewing on behalf of AutomatedTester April 25, 2026 11:54 View session

Copilot AI reviewed Apr 25, 2026

View reviewed changes

Comment thread javascript/atoms/test/shown_typescript_test.html Outdated

AutomatedTester and others added 8 commits April 30, 2026 11:48

[JavaScript] Move 'isDisplayed' atom to be typescript

df962f6

Use typescript output

f74c0c6

move test to not have closure

5dd120c

formatting

db1e420

Handle comments

b50a952

AutomatedTester force-pushed the atoms-ts-isdisplayed branch from c21f959 to 9c5905f Compare April 30, 2026 10:48

Copilot AI review requested due to automatic review settings April 30, 2026 11:34

Copilot started reviewing on behalf of AutomatedTester April 30, 2026 11:35 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

AutomatedTester and others added 2 commits April 30, 2026 13:44

Copilot AI review requested due to automatic review settings April 30, 2026 13:43

Copilot started reviewing on behalf of AutomatedTester April 30, 2026 13:43 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

Uh oh!

Conversation

AutomatedTester commented Apr 8, 2026

🔗 Related Issues

💥 What does this PR do?

🔧 Implementation Notes

💡 Additional Considerations

🔄 Types of changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development