Skip to content

Conversation

@selenium-ci
Copy link
Member

@selenium-ci selenium-ci commented Nov 15, 2025

This is an automated pull request to update pinned browsers and drivers

Merge after verify the new browser versions properly passing the tests and no bugs need to be filed

@selenium-ci selenium-ci added the B-build Includes scripting, bazel and CI integrations label Nov 15, 2025
@qodo-merge-pro
Copy link
Contributor

qodo-merge-pro bot commented Nov 15, 2025

PR Compliance Guide 🔍

(Compliance updated until commit f375733)

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status:
No auditing: The changes only update external archive URLs and hashes without adding or invoking any
critical actions that would require audit logging, so no audit events are introduced or
modified.

Referred Code
        url = "https://ftp.mozilla.org/pub/firefox/releases/146.0b4/linux-x86_64/en-US/firefox-146.0b4.tar.xz",
        sha256 = "bb585a3087f53b754bc36d58b2b7fee32b2674676f36aba4026c0cd495ce0016",
        build_file_content = """
load("@aspect_rules_js//js:defs.bzl", "js_library")
package(default_visibility = ["//visibility:public"])

filegroup(
    name = "files",
    srcs = glob(["**/*"]),
)

exports_files(["firefox/firefox"])

js_library(
    name = "firefox-js",
    data = [":files"],
)
""",
    )

    dmg_archive(


 ... (clipped 191 lines)

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status:
No error handling: The added lines only change url and sha256 values in Bazel repository rules without
introducing error handling logic; any fetch/verification errors are managed by Bazel, not
this PR code.

Referred Code
        url = "https://ftp.mozilla.org/pub/firefox/releases/146.0b4/linux-x86_64/en-US/firefox-146.0b4.tar.xz",
        sha256 = "bb585a3087f53b754bc36d58b2b7fee32b2674676f36aba4026c0cd495ce0016",
        build_file_content = """
load("@aspect_rules_js//js:defs.bzl", "js_library")
package(default_visibility = ["//visibility:public"])

filegroup(
    name = "files",
    srcs = glob(["**/*"]),
)

exports_files(["firefox/firefox"])

js_library(
    name = "firefox-js",
    data = [":files"],
)
""",
    )

    dmg_archive(


 ... (clipped 191 lines)

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status:
External sources: The PR updates external url endpoints and sha256 pins for browser archives; while hashes
are provided, no additional validation or integrity policy is shown within the diff beyond
Bazel’s verification.

Referred Code
        url = "https://ftp.mozilla.org/pub/firefox/releases/146.0b4/linux-x86_64/en-US/firefox-146.0b4.tar.xz",
        sha256 = "bb585a3087f53b754bc36d58b2b7fee32b2674676f36aba4026c0cd495ce0016",
        build_file_content = """
load("@aspect_rules_js//js:defs.bzl", "js_library")
package(default_visibility = ["//visibility:public"])

filegroup(
    name = "files",
    srcs = glob(["**/*"]),
)

exports_files(["firefox/firefox"])

js_library(
    name = "firefox-js",
    data = [":files"],
)
""",
    )

    dmg_archive(


 ... (clipped 191 lines)

Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

Previous compliance checks

Compliance check up to commit 8693a4b
Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status:
No Auditing: The new changes only update URLs and checksums for archives and do not introduce or modify
any logging of critical actions, making audit coverage unverifiable from this diff.

Referred Code
        url = "https://ftp.mozilla.org/pub/firefox/releases/146.0b3/linux-x86_64/en-US/firefox-146.0b3.tar.xz",
        sha256 = "657222223c744872a599633ea6e570e76eb8622c0955b84173352b345f456732",
        build_file_content = """
load("@aspect_rules_js//js:defs.bzl", "js_library")
package(default_visibility = ["//visibility:public"])

filegroup(
    name = "files",
    srcs = glob(["**/*"]),
)

exports_files(["firefox/firefox"])

js_library(
    name = "firefox-js",
    data = [":files"],
)
""",
    )

    dmg_archive(


 ... (clipped 3 lines)

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status:
No Error Handling: The added lines configure external downloads (url, sha256) without visible error handling
or fallbacks for fetch/verification failures within this diff.

Referred Code
        url = "https://ftp.mozilla.org/pub/firefox/releases/146.0b3/linux-x86_64/en-US/firefox-146.0b3.tar.xz",
        sha256 = "657222223c744872a599633ea6e570e76eb8622c0955b84173352b345f456732",
        build_file_content = """
load("@aspect_rules_js//js:defs.bzl", "js_library")
package(default_visibility = ["//visibility:public"])

filegroup(
    name = "files",
    srcs = glob(["**/*"]),
)

exports_files(["firefox/firefox"])

js_library(
    name = "firefox-js",
    data = [":files"],
)
""",
    )

    dmg_archive(


 ... (clipped 3 lines)

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status:
External Input Trust: The PR updates external download URLs and checksums without visible validation logic or
integrity enforcement beyond static sha256 fields, which cannot be fully assessed from
this diff.

Referred Code
        url = "https://ftp.mozilla.org/pub/firefox/releases/146.0b3/linux-x86_64/en-US/firefox-146.0b3.tar.xz",
        sha256 = "657222223c744872a599633ea6e570e76eb8622c0955b84173352b345f456732",
        build_file_content = """
load("@aspect_rules_js//js:defs.bzl", "js_library")
package(default_visibility = ["//visibility:public"])

filegroup(
    name = "files",
    srcs = glob(["**/*"]),
)

exports_files(["firefox/firefox"])

js_library(
    name = "firefox-js",
    data = [":files"],
)
""",
    )

    dmg_archive(


 ... (clipped 3 lines)

Learn more about managing compliance generic rules or creating your own custom rules

@qodo-merge-pro
Copy link
Contributor

qodo-merge-pro bot commented Nov 15, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Use a constant for version strings

To improve maintainability, define a constant for the hardcoded Firefox version
string "146.0b3" and use it to construct the download URLs for both Linux and
macOS.

common/repositories.bzl [51-76]

+_FIREFOX_BETA_VERSION = "146.0b3"
+
 http_archive(
     name = "linux_beta_firefox",
-    url = "https://ftp.mozilla.org/pub/firefox/releases/146.0b3/linux-x86_64/en-US/firefox-146.0b3.tar.xz",
+    url = "https://ftp.mozilla.org/pub/firefox/releases/{v}/linux-x86_64/en-US/firefox-{v}.tar.xz".format(v = _FIREFOX_BETA_VERSION),
     sha256 = "657222223c744872a599633ea6e570e76eb8622c0955b84173352b345f456732",
     ...
 )
 
 dmg_archive(
     name = "mac_beta_firefox",
-    url = "https://ftp.mozilla.org/pub/firefox/releases/146.0b3/mac/en-US/Firefox%20146.0b3.dmg",
+    url = "https://ftp.mozilla.org/pub/firefox/releases/{v}/mac/en-US/Firefox%20{v}.dmg".format(v = _FIREFOX_BETA_VERSION),
     sha256 = "a2b84419b1f22964ea4fe355cf2613c5e47da1a67f6df58518b3823091e3557f",
     ...
 )

[To ensure code accuracy, apply this suggestion manually]

Suggestion importance[1-10]: 7

__

Why: This is a valuable suggestion that improves maintainability by applying the DRY principle, making future version updates easier and less error-prone.

Medium
  • Update

@selenium-ci selenium-ci force-pushed the pinned-browser-updates branch 2 times, most recently from e77907c to dfe76ff Compare November 17, 2025 00:42
@selenium-ci selenium-ci force-pushed the pinned-browser-updates branch from dfe76ff to f375733 Compare November 18, 2025 00:40
@navin772 navin772 merged commit 0161351 into trunk Nov 18, 2025
81 of 82 checks passed
@navin772 navin772 deleted the pinned-browser-updates branch November 18, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B-build Includes scripting, bazel and CI integrations Review effort 1/5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants